Move markInitialized/reconnect after status code check in Streamable HTTP transport - #851
Open
rameshreddy-adutla wants to merge 1 commit into
Conversation
markInitialized() and reconnect() ran before the status check, so a 405 from a server without Streamable HTTP still triggered a GET and left a duplicate SSE session during transport fallback. Only do this on 2xx. Fixes modelcontextprotocol#773.
rameshreddy-adutla
force-pushed
the
fix/773-reconnect-before-status-check
branch
from
September 28, 2026 12:37
5c47844 to
128c06f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
markInitialized()andreconnect()inside the 2xx success branch inHttpClientStreamableHttpTransport#sendMessageso they are only called when the server actually accepted the connection.Problem
When connecting to an MCP server that doesn't support Streamable HTTP transport (returns 405 Method Not Allowed), the transport still calls
markInitialized()andreconnect()before checking the status code. This triggers an unnecessary GET request, causing duplicate SSE sessions when using transport fallback (Streamable HTTP → SSE).The root cause is in the
flatMapchain at line ~480:markInitialized()andreconnect()execute unconditionally before the status code is evaluated on the next line.Fix
Move the
markInitialized()/reconnect()block inside theif (statusCode >= 200 && statusCode < 300)branch. This ensures:Testing
All 98 Streamable HTTP transport tests pass. The 1 pre-existing failure (
startContainer) is a Docker/Testcontainers infrastructure issue unrelated to this change.Fixes #773