Skip to content

Preserve configured server capabilities - #1146

Open
zsewasdsdsd wants to merge 1 commit into
modelcontextprotocol:mainfrom
zsewasdsdsd:fix/preserve-server-capabilities
Open

zsewasdsdsd wants to merge 1 commit into
modelcontextprotocol:mainfrom
zsewasdsdsd:fix/preserve-server-capabilities

Conversation

@zsewasdsdsd

Copy link
Copy Markdown

Fixes #1086

Preserve explicitly configured server capabilities instead of unconditionally adding the logging capability when constructing McpAsyncServer.

This applies to both single-session and Streamable HTTP server transports.

Tests:

  • Added regression coverage for both async server transport variants
  • Verified the regression tests fail before the fix and pass after it
  • mcp-core: 420 tests passed, 0 failures, 0 errors

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServerCapabilities.logging is added unconditionally, overriding the caller's explicit capabilities

1 participant