-
Notifications
You must be signed in to change notification settings - Fork 437
mcp: add optional issuer validator for pre-registered client validation (SEP-2352) #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
guglielmo-san
merged 5 commits into
main
from
guglielmoc/SEP-2352_authorization_server_binding
May 29, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5f30446
feat: add optional issuer validation to ClientCredentials to ensure b…
guglielmo-san c1977db
Merge branch 'main' into guglielmoc/SEP-2352_authorization_server_bin…
guglielmo-san e57c858
feat: add authutil.IssuersEqual and update issuer validation to ignor…
guglielmo-san 5ffed15
refactor: standardize issuer comparison to use consistent trailing sl…
guglielmo-san bdfd5db
Merge branch 'main' into guglielmoc/SEP-2352_authorization_server_bin…
guglielmo-san File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Copyright 2026 The Go MCP SDK Authors. All rights reserved. | ||
| // Use of this source code is governed by the license | ||
| // that can be found in the LICENSE file. | ||
|
|
||
| package authutil | ||
|
|
||
| import "strings" | ||
|
|
||
| // IssuersEqual reports whether two OAuth 2.0 authorization server issuer | ||
| // identifiers refer to the same server comparing them without the final trailing slash. | ||
| func IssuersEqual(a, b string) bool { | ||
| return strings.TrimSuffix(a, "/") == strings.TrimSuffix(b, "/") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright 2026 The Go MCP SDK Authors. All rights reserved. | ||
| // Use of this source code is governed by the license | ||
| // that can be found in the LICENSE file. | ||
|
|
||
| package authutil | ||
|
|
||
| import "testing" | ||
|
|
||
| func TestIssuersEqual(t *testing.T) { | ||
| tests := []struct { | ||
| a, b string | ||
| want bool | ||
| }{ | ||
| {"https://issuer.example.com", "https://issuer.example.com", true}, | ||
| {"https://issuer.example.com/", "https://issuer.example.com", true}, | ||
| {"https://issuer.example.com", "https://issuer.example.com/", true}, | ||
| {"https://issuer.example.com/", "https://issuer.example.com/", true}, | ||
| {"https://issuer.example.com/tenant", "https://issuer.example.com/tenant", true}, | ||
| {"https://issuer.example.com/tenant/", "https://issuer.example.com/tenant", true}, | ||
| {"https://issuer.example.com", "https://other.example.com", false}, | ||
| {"https://issuer.example.com/a", "https://issuer.example.com/b", false}, | ||
| {"", "", true}, | ||
| } | ||
| for _, tt := range tests { | ||
| if got := IssuersEqual(tt.a, tt.b); got != tt.want { | ||
| t.Errorf("IssuersEqual(%q, %q) = %v, want %v", tt.a, tt.b, got, tt.want) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.