mcp: add an sse event size cap - #1205
Open
yarolegovich wants to merge 6 commits into
Open
Conversation
yarolegovich
force-pushed
the
yarolegovich/add-request-size-checks
branch
from
August 28, 2026 07:01
6112a13 to
a433a9f
Compare
Comment on lines
+68
to
+70
| // defaultMaxEventSize bounds the number of bytes buffered for a single SSE | ||
| // event before the input gets rejected. | ||
| const defaultMaxEventSize = 16 << 20 // 16 MiB |
Contributor
There was a problem hiding this comment.
should not we allow the possibility to override this value?
Member
Author
There was a problem hiding this comment.
initially was thinking about hiding it under mcp_go_debug, together with json depth check, but thinking about it it's going to be more consistent if we expose this as a config and omit mcp go debug for the depth check, I can't imagine a legitimate need for very deep nesting
guglielmo-san
previously approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update sse I/O code to limit the amount of memory a single non-terminated event can take