Skip to content

Comments

Fix CreateMessageRequestParams.Metadata type to JsonObject#1354

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-metadata-jsonobject-type
Open

Fix CreateMessageRequestParams.Metadata type to JsonObject#1354
Copilot wants to merge 4 commits intomainfrom
copilot/fix-metadata-jsonobject-type

Conversation

Copy link
Contributor

Copilot AI commented Feb 22, 2026

  • Confirm MCP spec defines CreateMessageRequest.params.metadata as object type ({ [key: string]: unknown })
  • Confirm all other _meta/Meta properties in C# SDK use JsonObject?
  • Change CreateMessageRequestParams.Metadata from JsonElement? to JsonObject?
  • Add serialization roundtrip test for Metadata in CreateMessageRequestParamsTests
  • Build and test to verify no regressions

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…nObject?

Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
@stephentoub stephentoub added the breaking-change This issue or PR introduces a breaking change label Feb 22, 2026
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
@stephentoub stephentoub changed the title [WIP] Fix CreateMessageRequestParams.Metadata type to JsonObject Fix CreateMessageRequestParams.Metadata type to JsonObject Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This issue or PR introduces a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants