Prevent cancellation of initialize request per MCP spec#1350
Open
Prevent cancellation of initialize request per MCP spec#1350
Conversation
Per MCP spec: "The initialize request MUST NOT be cancelled by clients" Client side: Skip RegisterCancellation in SendRequestAsync for initialize requests so that no notifications/cancelled is sent even if the cancellation token fires (e.g. from timeout). Server side: Don't store initialize request in _handlingRequests so incoming cancellation notifications can't cancel it. Added tests for both behaviors. Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Contributor
|
@copilot fix the pr title and description |
Contributor
Author
Updated the PR description. I'm unable to update the PR title through my available tools — could you update it to "Prevent cancellation of initialize request per MCP spec"? |
Copilot
AI
changed the title
[WIP] Fix initialize cancellation handling based on MCP spec
Prevent cancellation of initialize request per MCP spec
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the MCP spec (cancellation.mdx, behavior requirement #2): "The
initializerequest MUST NOT be cancelled by clients."Changes
Client side (
McpSessionHandler.SendRequestAsync): SkipRegisterCancellationwhen the request method isinitialize, so nonotifications/cancellednotification is sent even if the cancellation token fires (e.g., from timeout).Server side (
McpSessionHandler.ProcessMessagesAsync): Don't store the initialize request in_handlingRequests, so incoming cancellation notifications can't cancel the initialize handler.Tests
InitializeTimeout_DoesNotSendCancellationNotification: Verifies the client doesn't send a cancellation notification when initialize times out.Server_IgnoresCancellationNotificationForInitializeRequest: Verifies the server ignores a cancellation notification targeting the initialize request and still responds successfully.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.