chore: update Node.js version in the conformance action to 22#162
Open
maciej-kisiel wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
chore: update Node.js version in the conformance action to 22#162maciej-kisiel wants to merge 1 commit intomodelcontextprotocol:mainfrom
maciej-kisiel wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
With Node.js 20 the action fails with:
```
SyntaxError: The requested module 'fs' does not provide an export named 'globSync'
at ModuleJob._instantiate (node:internal/modules/esm/module_job:213:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:320:5)
at async ModuleLoader.import (node:internal/modules/esm/loader:606:24)
at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5)
```
`fs.globSync` was added in Node.js 22.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With Node.js 20 the action fails with:
fs.globSyncwas added in Node.js 22.How Has This Been Tested?
Successful conformance runs with this parameter overridden to
22in modelcontextprotocol/go-sdk#814.Breaking Changes
I believe none.
Types of changes
Checklist
Additional context