chore: enable and fixes rules from gocritic

[mmorel-35]

Enables all gocritic rules by default, then excludes the one non compliant then fix one rule per commit
Covers #245 gocritic part only

[kolyshkin]

Overall LGTM, left some nits.

[kolyshkin]

LGTM; @thaJeztah PTAL

[thaJeztah]

Oh! You need to rebase, because go1.27 is not "stable", so GolangCi-lint needed updating

[thaJeztah]

needs a rebase (see above), but LGTM after the list is updated to the ones we actually hit; #246 (comment)

[thaJeztah]

Perhaps just explicitly ignore the error, then we don't need a nolint comment;

Suggested change

	//nolint:errcheck // Ignore error in tests
	Unmount(dir)
	_ = Unmount(dir)

[thaJeztah]

I also don't think moving this to a utility is correct; it changes semantics because it now unmounts immediately? If we want to keep that behavior, then we could do something like;

var toUnMount []string

t.Cleanup(func() {
    for _ m := range toUnmount {
        _ = Unmount(m)
   }
})

(either t.Cleanup or defer, depending on go version supported, but I'd be fine bumping to a slightly newer version if needed)

[thaJeztah]

Possibly the utility of #253 could be used if it's modified to take a variadic strings.

[thaJeztah]

Same here; we can also defer the unmount explicitly ignore errors here as well;

_ = Unmount(dir) //nolint:errcheck // Ignore error in tests

If the defer / cleanup wasn't relevant to the test, we can just inline it without the cleanup.