Skip to content

host: Log loaded extensions and providers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vvoland wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

host: Log loaded extensions and providers #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions host/host.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"slices"
"strings"

"github.com/containerd/log"
"github.com/moby/extensions"
"github.com/moby/extensions/clientpoint"
servicev0 "github.com/moby/extensions/extpoints/service/v0"
Expand Down Expand Up @@ -228,6 +229,11 @@ type loadedExtension struct {
close func(context.Context) error
}

type registeredExtension struct {
identity extensions.ExtensionIdentity
providers []extensions.Provider
}

// hostedExtension is the runtime-neutral declaration and lifecycle surface
// needed to adapt an externally hosted extension to the broker.
type hostedExtension struct {
Expand Down Expand Up @@ -297,6 +303,7 @@ func New(ctx context.Context, optionList ...Option) (_ *Host, retErr error) {
b := broker.New()
conns := make(map[extensions.ExtensionID]grpc.ClientConnInterface)
var loaded []loadedExtension
var registered []registeredExtension
publishedServices := make(map[extensions.ExtensionID]map[extensions.PointID][]string)
publishedOwners := make(map[string]extensions.ExtensionID)
var inProcessServices []servicegrpc.Service
Expand Down Expand Up @@ -341,6 +348,7 @@ func New(ctx context.Context, optionList ...Option) (_ *Host, retErr error) {
if err := b.Register(identity, extensions.New(decl)); err != nil {
return nil, err
}
registered = append(registered, registeredExtension{identity: identity, providers: admittedProviders})
}
l := launcher.Launcher{
RuntimeDir: opts.runtimeDir,
Expand Down Expand Up @@ -374,6 +382,7 @@ func New(ctx context.Context, optionList ...Option) (_ *Host, retErr error) {
if err := b.Register(identity, extensions.New(decl)); err != nil {
return nil, err
}
registered = append(registered, registeredExtension{identity: identity, providers: admittedProviders})
conns[identity.ID] = started.Conn
}
}
Expand Down Expand Up @@ -405,6 +414,21 @@ func New(ctx context.Context, optionList ...Option) (_ *Host, retErr error) {
if err := b.Init(ctx, opts.extensionConfig); err != nil {
return nil, err
}
for _, ext := range registered {
providerIDs := make([]string, len(ext.providers))
for i, provider := range ext.providers {
providerIDs[i] = string(provider.Point)
}
fields := log.Fields{
"extension": ext.identity.ID,
"origin": ext.identity.Origin.Kind,
"providers": providerIDs,
}
if executable := ext.identity.Origin.Executable; executable != nil {
fields["path"] = executable.Path
}
log.G(ctx).WithFields(fields).Info("loaded extension")
}
return &Host{broker: b, conns: conns, loaded: loaded, publishedServices: publishedServices, inProcessServices: inProcessServices, callback: callback}, nil
}

Expand Down