Brain GUI modernization (Phase 4)#14102
Open
payamsash wants to merge 1 commit into
Open
Conversation
payamsash
requested review from
drammock,
larsoner and
wmvanvliet
as code owners
July 26, 2026 12:28
payamsash
changed the title
wmvanvliet
reviewed
Jul 26, 2026
| assert brain._alpha == 0.5 | ||
|
|
||
| brain.set_cortex_colormap("bone") | ||
| assert brain._cortex_preset == "bone" |
Contributor
There was a problem hiding this comment.
this doesn't test whether the new colors are actually shown, like you do below with changing surf
| rng=rng, | ||
| opacity=opacity, | ||
| name=name, | ||
| smooth=smooth, |
Contributor
There was a problem hiding this comment.
Why a new smooth parameter? We already had controls for the amount of smoothing, which you could set to 1 to turn it off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Phase 4 of #14042 and following #14085
What does this implement/fix?
add
surfandcortexoptions to GUIAdditional information
Claude reviewed the code and I understand what has been modified.