Skip to content

Weekly Permissions sync 2026-04-25#1511

Open
marabooy wants to merge 1 commit intomasterfrom
permissions-update/2026-04-25
Open

Weekly Permissions sync 2026-04-25#1511
marabooy wants to merge 1 commit intomasterfrom
permissions-update/2026-04-25

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2026-04-25

@marabooy marabooy requested a review from a team as a code owner April 25, 2026 00:27
Copilot AI review requested due to automatic review settings April 25, 2026 00:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Weekly permissions metadata sync updating the permissions catalog and provisioning metadata to reflect newly available scopes, updated resource app IDs, and newly exposed API routes.

Changes:

  • Adds new AgentRegistration.Read.All and AgentRegistration.ReadWrite.All permission definitions and enables them in provisioning metadata (with populated GUID IDs).
  • Updates AppGalleryIntegrationRequest.* entries in provisioning metadata to use a new resourceAppId.
  • Extends several existing permissions’ pathSets with new API routes (e.g., agent sign-in sessions, Cloud PC set device name, new report functions) and includes minor text fixes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
permissions/new/provisioningInfo.json Populates/enables AgentRegistration permission variants and updates resourceAppId for multiple AppGalleryIntegrationRequest permissions.
permissions/new/permissions.json Introduces new AgentRegistration permission blocks, adjusts some permission descriptions, and adds new method/path mappings for newly supported endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3113 to +3116
"adminDisplayName": "Read all agent registrations",
"adminDescription": "Allows the user to read all agent registration information",
"userDisplayName": "Read all agent registrations",
"userDescription": "Allows the app to read agent registration information.",
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DelegatedWork scheme, adminDescription says "Allows the user to read..." but these consent descriptions elsewhere describe what the app/client can do (typically "Allows the app/client to ... on behalf of the signed-in user"). This wording is inconsistent and may confuse consent UX; please update adminDescription to match the established phrasing pattern (e.g., like AuditLog.Read.All / AgentIdentity.Read.All).

Copilot uses AI. Check for mistakes.
Comment on lines +3149 to +3152
"adminDisplayName": "Read and write all agent registrations",
"adminDescription": "Allows the user to read and write all agent registration information",
"userDisplayName": "Read and write all agent registrations",
"userDescription": "Allows the app to read and write agent registration information.",
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as AgentRegistration.Read.All: DelegatedWork adminDescription says "Allows the user to read and write..." rather than describing what the app can do on behalf of the signed-in user. Please align the wording with the surrounding permission descriptions to avoid confusing consent text.

Copilot uses AI. Check for mistakes.
Comment on lines +3169 to +3174
"methods": [
"GET"
],
"paths": {
"/copilot/agentRegistrations/{agentId}": "least=DelegatedWork,Application"
}
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentRegistration.ReadWrite.All marks the GET /copilot/agentRegistrations/{agentId} route as least-privileged for both schemes. Since AgentRegistration.Read.All is introduced specifically for read access, the ReadWrite scope should typically not be the least-privileged permission for GET (many other *.ReadWrite.* permissions map GET paths to an empty string to avoid recommending an over-privileged scope). Consider changing this GET path mapping to "" and letting AgentRegistration.Read.All be the least-privileged permission for GET.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants