Repository navigation
Fix/preserve additional formatting options - #1929
Merged
Dirk Bäumer (dbaeumer) merged 8 commits intoNov 4, 2026
Merged
Dirk Bäumer (dbaeumer) merged 8 commits into
Dirk Bäumer (dbaeumer) merged 8 commits into
Conversation
added 4 commits
October 28, 2026 16:38
…github.com/JohannesStoehr/vscode-languageserver-node into fix/preserve-additional-formatting-options
Contributor
Author
|
@microsoft-github-policy-service agree company="Iconparc" |
Member
|
Johannes Stöhr (@JohannesStoehr) the CI pipeline fails: |
Member
|
Johannes Stöhr (@JohannesStoehr) the CI pipeline fails: |
Contributor
Author
|
Dirk Bäumer (@dbaeumer) Sorry, that I missed that. I fixed the test. |
Dirk Bäumer (dbaeumer)
approved these changes
Nov 3, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Nov 3, 2026
Christof Marti (chrmarti)
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP-Specification for Formatting specifies that the client can provide custom options but VSCode currently ignores them.
The types vscode.FormattingOptions and vscode-languageserver-protocol.FormattingOptions already provide the option for custom settings, but the helper Function asFormattingOptions ignores them.
This PR changes asFormattingOptions to use all provided options. Since the options can only be a boolean, number or string a shallow copy is enough.
The test case is kept similar to the File Operations suite, where parameters to the server are already verified in tests.