indexer: open files with FILE_SHARE_DELETE on Windows - #51
Merged
Conversation
Use CreateFileW with FILE_SHARE_DELETE so that files being read during indexing do not block deletion or renaming on Windows. Adds _open_shared() helper that calls CreateFileW with FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE on Windows and falls back to plain open() on other platforms. Both callsites in build_document (source file reads) and the .gitignore reader in walk_source_files now use _open_shared().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, \open()\ acquires an exclusive delete lock on the file, which prevents deletion or renaming while the indexer holds the handle open. This causes friction when a developer deletes or renames a source file that happens to be mid-index.
Change
Adds a _open_shared()\ helper in \indexserver/indexer.py\ that uses \CreateFileW\ with \FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE\ on Windows. On other platforms it falls back to plain \open().
Both file-read callsites now use it:
Tests
All 1146 existing tests pass.