Skip to content

Bump Microsoft.CodeAnalysis.PublicApiAnalyzers to 5.10.0-1 preview#9865

Open
Evangelink wants to merge 1 commit into
mainfrom
dev/amauryleve/automatic-couscous
Open

Bump Microsoft.CodeAnalysis.PublicApiAnalyzers to 5.10.0-1 preview#9865
Evangelink wants to merge 1 commit into
mainfrom
dev/amauryleve/automatic-couscous

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Moves MicrosoftCodeAnalysisPublicApiAnalyzersVersion (which also drives Microsoft.CodeAnalysis.BannedApiAnalyzers) from stable 5.6.0 to the roslyn main preview line 5.10.0-1.26360.111, consumed from the dnceng dotnet-tools feed already configured in NuGet.config.

Why

In preparation for picking up dotnet/roslyn#84437"Exclude [Embedded] APIs from public/internal API tracking" — which lets internal [Embedded] types opt out of InternalAPI.*.txt / PublicAPI.*.txt tracking.

⚠️ Not final yet

5.10.0-1.26360.111 was built 2026-07-10 22:25 UTC, ~46 min before the #84437 merge (2026-07-10 23:11 UTC), so it does not yet contain the fix. The main/5.10.0 line has not produced a post-merge build on the feed as of this PR. This must be re-pinned to the first post-merge main build (5.10.0-1.26361.* or later) to actually gain the feature.

Validation

Full .\build.cmd -c Release — the 5.6→5.10 analyzer jump produced 0 RS00xx (PublicAPI/BannedAPI) diagnostics, i.e. no public-API tracking fallout. (Any CA1416 errors seen locally in FileLoggerTests.cs are a pre-existing, unrelated platform-compat issue tracked separately.)

Tracking context: #9091 (Task 5).

Move from stable 5.6.0 to the roslyn main (5.10.0-1.*) preview line on the
dnceng dotnet-tools feed, in preparation for picking up dotnet/roslyn#84437
(exclude [Embedded] APIs from public/internal API tracking).

NOTE: 5.10.0-1.26360.111 predates the #84437 merge (2026-07-10 23:11 UTC) by
~46 min, so it does not yet contain the fix. Re-pin to the first post-merge
main build (5.10.0-1.26361.* or later) once it ships. Full Release build is
clean for this bump (0 RS00xx diagnostics).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3f7eb1fb-6df4-4665-9f9a-c17d60883e66
Copilot AI review requested due to automatic review settings July 11, 2026 20:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Public API analyzers to a Roslyn preview build in preparation for [Embedded] API exclusion.

Changes:

  • Bumps both API analyzer packages to 5.10.0-1.26360.111.
  • Documents the tracked Roslyn change and notes that the selected build predates it.
Show a summary per file
File Description
Directory.Packages.props Updates and documents the shared analyzer version pin.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread Directory.Packages.props
@Evangelink Evangelink marked this pull request as ready for review July 11, 2026 20:31
@Evangelink Evangelink enabled auto-merge (squash) July 11, 2026 20:31
@Evangelink Evangelink added the state/needs-review Awaiting review from the team. label Jul 11, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

Clean dependency version bump — no code, API, or behavioral changes. The comment clearly documents the temporary state and the re-pin requirement.

Verdict Table

# Dimension Verdict
1 Algorithmic Correctness N/A
2 Threading & Concurrency N/A
3 Security & IPC Contract Safety N/A
4 Public API & Binary Compatibility N/A
5 Performance & Allocations N/A
6 Cross-TFM Compatibility N/A
7 Resource & IDisposable Management N/A
8 Defensive Coding at Boundaries N/A
9 Localization & Resources N/A
10 Test Isolation N/A
11 Assertion Quality N/A
12 Flakiness Patterns N/A
13 Test Completeness & Coverage N/A
14 Error Messages & Diagnostics N/A
15 Code Style & Conventions ✅ Clean
16 Documentation & Comments ✅ Clean
17 Build & Packaging ✅ Clean
18 Naming N/A
19 Nullability N/A
20 Logging & Telemetry N/A
21 CLI Options N/A
22 PowerShell & Scripting N/A

Result: No issues found. The inline comment accurately documents that this preview build predates the target roslyn merge and must be re-pinned — good transparency. The dotnet-tools feed is already in NuGet.config, and the BannedApiAnalyzers version is correctly derived via $(MicrosoftCodeAnalysisPublicApiAnalyzersVersion).

One note: since the PR description itself says this version does not yet contain the desired fix (dotnet/roslyn#84437), ensure the follow-up re-pin happens before this branch ships to a release. The in-code NOTE: comment serves as a good breadcrumb for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants