Skip to content

Fix TreeNodeFilter OR-pattern diagnostics#7415

Open
Evangelink wants to merge 1 commit intomainfrom
dev/amauryleve/tree-node-filter
Open

Fix TreeNodeFilter OR-pattern diagnostics#7415
Evangelink wants to merge 1 commit intomainfrom
dev/amauryleve/tree-node-filter

Conversation

@Evangelink
Copy link
Member

Description

  • Fixes https://github.com/--treenode-filter pattern matching is at least non obvious, potentially errored #7300 by clarifying behavior and improving failure diagnostics for unsupported parenthesized full-path OR patterns.
  • Root cause: Tree-node OR is valid within a single path segment, but patterns like (/A/B/C/X)|(/A/B/C/Y) hit separator processing inside parentheses and throw a generic invalid operation.
  • Changes:
    • Add regression tests for supported single-segment OR and exact-match behavior in TreeNodeFilterTests.cs.
    • Improve parser exception guidance and grammar remarks in TreeNodeFilter.cs.
    • Add changelog entry in Changelog-Platform.md.

Validation

Notes

This change does not expand grammar to support full-path OR in parentheses; it adds explicit guidance and test coverage for current supported syntax.

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have doubts that the problem here is clarity of error message. The behavior seems buggy IMO. Let's discuss offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants