fix(macos): expose React-RCTUIKit module to RCTSwiftUI Swift consumers#2958
Open
tvinhas wants to merge 1 commit into
Open
fix(macos): expose React-RCTUIKit module to RCTSwiftUI Swift consumers#2958tvinhas wants to merge 1 commit into
tvinhas wants to merge 1 commit into
Conversation
This was referenced May 13, 2026
Open
Saadnajmi
suggested changes
Jun 5, 2026
Comment on lines
+9
to
+19
| // [macOS] Pull in the ObjC @compatibility_alias declarations for | ||
| // `RCTPlatformView` (UIView/NSView) and `RCTUIColor` (UIColor/NSColor) | ||
| // from RCTUIKit. Without this import the Swift file used to re-declare | ||
| // these as local `public typealias`es, which shadowed the ObjC aliases | ||
| // and forced every consumer of this module to choose between the Swift | ||
| // and ObjC name. After the React-RCTUIKit pod dep is wired in | ||
| // RCTSwiftUI.podspec, the import is the canonical source of truth. | ||
| // `RCTPlatformHostingController` stays as a Swift typealias below — it | ||
| // wraps NSHostingController / UIHostingController which are SwiftUI | ||
| // generics and not in the ObjC compat layer. | ||
| import React_RCTUIKit |
Collaborator
There was a problem hiding this comment.
We don't need this giant comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the
React-RCTUIKitpod intoRCTSwiftUIsoRCTSwiftUIContainerView.swiftcan import the ObjC-side@compatibility_aliasdeclarations (RCTPlatformView,RCTUIColor) directly, instead of carrying its own Swifttypealiasshadow copies of those names.
Two files, two coupled changes — must ship together. Removing the Swift typealiases without first wiring the pod dep would leave the Swift file with no source for
RCTPlatformView/RCTUIColorand break compilation.1.
RCTSwiftUI.podspec— addReact-RCTUIKitdependency