Fix CUDA Abs signed zero handling - #31832
Open
NIKHIL (Nikhi00718) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
NIKHIL (Nikhi00718)
marked this pull request as ready for review
August 9, 2026 18:26
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
NIKHIL (@Nikhi00718) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CUDA
_Abshelper currently returns-awhenevera > 0is false. For+0.0, that produces-0.0, which violates the ONNXAbsresult semantics and differs from the CPU execution provider. The same branch also leaves-0.0unchanged.Canonicalize both signed-zero inputs to positive zero before applying the existing sign handling. Other values, including NaNs and integer types supported by the helper, retain their existing behavior.
Fixes #31162.
Tests
+0.0and-0.0, checking the output sign bit and value.git diff --checkCUDA compilation and execution require the repository's CUDA CI environment, which was not available on this Windows workstation.