Skip to content

node-pty should have valid code, even in the build process #736

Description

(node:126535) ExperimentalWarning: CommonJS module /usr/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /usr/lib/node_modules/npm/node_modules/supports-color/index.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
npm warn deprecated cross-spawn-async@2.2.5: cross-spawn no longer requires a build toolchain, use it instead
npm error code 1
npm error path /home/ashton/ElectronProjects/Terminal/forge/node_modules/@octokit/rest/node_modules/node-pty
npm error command failed
npm error command sh -c node-gyp rebuild
npm error gyp info it worked if it ends with ok
npm error gyp info using node-gyp@3.8.0
npm error gyp info using node@23.3.0 | linux | x64
npm error (node:126556) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
npm error (Use `node --trace-deprecation ...` to show where the warning was created)
npm error gyp ERR! configure error 
npm error gyp ERR! stack Error: Command failed: /usr/bin/python -c import sys; print "%s.%s.%s" % sys.version_info[:3];
npm error gyp ERR! stack   File "<string>", line 1
npm error gyp ERR! stack     import sys; print "%s.%s.%s" % sys.version_info[:3];
npm error gyp ERR! stack                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
npm error gyp ERR! stack SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
npm error gyp ERR! stack 
npm error gyp ERR! stack     at genericNodeError (node:internal/errors:983:15)
npm error gyp ERR! stack     at wrappedFn (node:internal/errors:537:14)
npm error gyp ERR! stack     at ChildProcess.exithandler (node:child_process:414:12)
npm error gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm error gyp ERR! stack     at maybeClose (node:internal/child_process:1101:16)
npm error gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:305:5)
npm error gyp ERR! System Linux 6.12.3-arch1-1
npm error gyp ERR! command "/usr/bin/node" "/home/ashton/ElectronProjects/Terminal/forge/node_modules/.bin/node-gyp" "rebuild"
npm error gyp ERR! cwd /home/ashton/ElectronProjects/Terminal/forge/node_modules/@octokit/rest/node_modules/node-pty
npm error gyp ERR! node -v v23.3.0
npm error gyp ERR! node-gyp -v v3.8.0
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: /home/ashton/.npm/_logs/2024-12-11T15_47_25_985Z-debug-0.log

Activity

  1. Tyriar commented on Dec 17, 2024

    @Tyriar
    Contributor

    Not sure what you mean? Is the exit code not passed through, or?

  2. YeesterPlus commented on Dec 19, 2024

    @YeesterPlus
    Author

    it needs parenthesies in the installer

  3. YeesterPlus commented on Dec 19, 2024

    @YeesterPlus
    Author

    print "%s %s %s" -> print("%s %s %s")

  4. YeesterPlus commented on Dec 19, 2024

    @YeesterPlus
    Author

    this isn't asm nor heavily modified smalltalk

  5. locked and limited conversation to collaborators on Dec 20, 2024
  6. converted this issue into a discussion #747 on Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    info-neededIssue requires more information from poster

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions