Skip to content

fix(workspace-plugin): generate-api emits export-subpath rollups on Windows #36672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ray Knight (ArrayKnight) wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix(workspace-plugin): generate-api emits export-subpath rollups on Windows #36672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/workspace-plugin/src/executors/generate-api/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,13 @@ export function getExportSubpathConfigs(options: NormalizedOptions): IConfigFile
// they act as literal path segments that the subsequent "../" chain traverses through.
// path.resolve(configDir, "<projectRoot>/../../../../../../...") naturally normalizes to the correct path.
const configDir = dirname(opts.config);
// Normalized to posix separators: path.resolve emits backslashes on Windows, which
// would fail the '/index.d.ts' suffix check below and silently skip every subpath
// rollup on Windows machines (CI on Linux was unaffected).
const resolvedPrimaryEntry = resolve(
configDir,
primaryMainEntryTemplate.replace(/<unscopedPackageName>/g, unscopedPackageName),
);
).replace(/\\/g, '/');

const indexDtsSuffix = '/index.d.ts';
if (!resolvedPrimaryEntry.endsWith(indexDtsSuffix)) {
Expand Down