Skip to content

fix(react-storybook-addon-export-to-sandbox): find the addon registration on Windows #36671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ray Knight (ArrayKnight) wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

fix(react-storybook-addon-export-to-sandbox): find the addon registration on Windows #36671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...luentui-react-storybook-addon-export-to-sandbox-4a111ae2-83ac-4fad-8039-eeed61b69743.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: match backslash-separated preset paths so the addon finds its registration on Windows",
"packageName": "@fluentui/react-storybook-addon-export-to-sandbox",
"email": "array.knight@gmail.com",
"dependentChangeType": "patch"
}
6 changes: 5 additions & 1 deletion packages/react-components/react-storybook-addon-export-to-sandbox/src/webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ export function webpack(config: WebpackFinalConfig, options: WebpackFinalOptions
}

const identity = <T extends unknown>(value: T) => value;
const addonFilePattern = /react-storybook-addon-export-to-sandbox\/[a-z/]+.[jt]s$/;
// Both path separators on purpose: on Windows the registered preset name is an absolute
// path with backslashes (e.g. `...\react-storybook-addon-export-to-sandbox\temp\preset.ts`);
// a forward-slash-only pattern fails to find the registration, silently drops the addon
// options, and the full-source babel plugin then crashes on undefined `importMappings`.
const addonFilePattern = /react-storybook-addon-export-to-sandbox[\\/][a-z\\/]+.[jt]s$/;
const defaultOptions = {
webpackRule: {},
babelLoaderOptionsUpdater: identity,
Expand Down
Loading