Conversation
janechu
force-pushed
the
users/janechu/update-fixture-to-use-fast-build-repeat
branch
from
cdcc657 to
2eb1e1e
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add repeat to the list of fixtures built by build-fixtures.js - Add render_entry_with_templates WASM binding to expose render_entry_template_with_locator to the CLI (root custom elements receive full entry-level state rather than attribute-only state) - Update fast.js CLI to use render_entry_with_templates when templates are provided, so fixtures are rendered with the correct entry semantics - Regenerate repeat/index.html with the updated WASM build output Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Regenerate repeat/index.html after rebasing onto main (which includes PR #7403 entry-attribute stripping and PR #7380 when fixture). Changes reflect correct entry-element behavior: - Non-primitive binding attrs (list, someData) stripped from opening tag - test-element-no-item-repeat-binding now renders empty repeat since list="{{emptyList}}" overrides root list with [] in merged state Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janechu
force-pushed
the
users/janechu/update-fixture-to-use-fast-build-repeat
branch
from
2eb1e1e to
2dae200
Compare
…tate
TestElementEvent.list defaults to ["A"] (1 item), but the entry.html
was passing list="{{list}}" (2 items: Foo/Bar from root state), causing
the SSR to render 2 buttons while the Playwright test expected 1.
Fix: add eventList: ["A"] to state.json and use :list="{{eventList}}"
in entry.html so the property binding passes a 1-item list to the
element's SSR state (matching the JS component's initial value) while
keeping the array out of the rendered HTML attributes.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janechu
deleted the
users/janechu/update-fixture-to-use-fast-build-repeat
branch
janechu
added a commit
that referenced
this pull request
Apr 8, 2026
Regenerate repeat-event/index.html after rebasing onto main (which includes #7381 repeat fixture, #7380 when fixture, and #7403 entry-attribute stripping). Non-primitive binding attrs (items) are now stripped from entry element opening tags; primitive attrs (show-names="true") are preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
repeattest fixture to the set of fixtures built automatically by@microsoft/fast-build.This PR also fixes a gap in the
fast.jsCLI and WASM layer: therender_entry_with_templatesfunction was missing from the WASM bindings, so the CLI fell back to attribute-derived child state instead of the intended entry-level full-state rendering. A newrender_entry_with_templatesWASM export is added and the CLI is updated to use it, ensuring root custom elements in fixtures receive the complete root state (matching runtime behaviour).📑 Test Plan
Run
npm run build:fixtures -w @microsoft/fast-htmlto regenerate all fixtures — all six should build without errors. The Playwright tests for the repeat fixture can be verified by runningnpx playwright testinsidepackages/fast-html.✅ Checklist
General
$ npm run change