chore(fast-html): use @microsoft/fast-build to build ref fixture#7378
Merged
chore(fast-html): use @microsoft/fast-build to build ref fixture#7378
Conversation
d0c86bf to
9c64e48
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9c64e48 to
5812a98
Compare
There was a problem hiding this comment.
Pull request overview
Updates the @microsoft/fast-html test fixture set by adding a ref fixture and wiring it into the existing @microsoft/fast-build-based fixture build pipeline, aligning it with attribute, binding, and event.
Changes:
- Adds
reffixture inputs (entry.html,templates.html,state.json) for@microsoft/fast-build. - Regenerates
ref/index.htmlusing@microsoft/fast-buildoutput plus template injection. - Includes
refinpackages/fast-html/scripts/build-fixtures.jssonpm run build:fixturesbuilds it.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fast-html/test/fixtures/ref/templates.html | Adds declarative template using f-ref for the ref fixture. |
| packages/fast-html/test/fixtures/ref/state.json | Adds state input for the ref fixture build (empty state). |
| packages/fast-html/test/fixtures/ref/entry.html | Adds build entry HTML for the ref fixture (matches other buildable fixtures). |
| packages/fast-html/test/fixtures/ref/index.html | Updates generated fixture output to the fast-build produced HTML + injected <f-template> declarations. |
| packages/fast-html/scripts/build-fixtures.js | Adds ref to the list of fixtures built via @microsoft/fast-build. |
| change/@microsoft-fast-html-ref-eb80fd68-6df1-46bc-848d-f59cd9be4b49.json | Records the change request for the @microsoft/fast-html package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
reftest fixture to@microsoft/fast-htmland generates itsindex.htmlusing@microsoft/fast-build, consistent with the other fixtures (attribute,binding,event).The
reffixture coversf-refattribute directives, which bind a reference to a DOM element in a FAST template (e.g.<video f-ref="{video}"></video>). Becausef-refis client-side only,@microsoft/fast-buildstrips it from the rendered Declarative Shadow DOM and preserves only thedata-fe-chydration binding count so the FAST runtime can allocate the correct number of binding slots.🎫 Issues
No open issues directly addressed.
📑 Test Plan
npm run build:fixturesinpackages/fast-htmlruns cleanly and regeneratesref/index.html—f-refis stripped from shadow DOM output,data-fe-c-0-1binding annotation is preserved.attribute,binding,event) are unchanged.✅ Checklist
General
$ npm run change⏭ Next Steps
ref.spec.ts) covering hydration of thef-reffixture to verify client-side element reference assignment after SSR.