containerd2: build with default Go toolchain to fix stdlib CVEs#17985
Merged
jslobodzian merged 1 commit intoJul 14, 2026
Merged
Conversation
Drop 'BuildRequires: golang < 1.25' and set GOEXPERIMENT=ms_nocgo_opensslcrypto (Microsoft Go 1.25+ defaults to systemcrypto which needs CGO_ENABLED=1; containerd builds CGO_ENABLED=0). Resolves Go stdlib CVE-2026-25679, CVE-2026-27139, CVE-2026-33811, CVE-2026-39836 (was built on Go 1.24.13).
c398dee to
485647a
Compare
| BuildRequires: make | ||
| BuildRequires: systemd-rpm-macros | ||
|
|
||
| Requires: runc >= 1.2.2 |
Collaborator
There was a problem hiding this comment.
question: Given the new requirement for OpenSSL stack at runtime, is a Requires: openssl-libs needed?
Note: We're likely installing containerd on systems that have OpenSSL present already, so we might be fine without it.
jslobodzian
approved these changes
Jul 14, 2026
jslobodzian
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed via fasttrack-prs skill: spec review PASS, Fast-track 3.0 PR-check build succeeded.
Collaborator
|
Auto cherry-pick results:
Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1159885&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
*-staticsubpackages, etc.) have had theirReleasetag incremented.*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
containerd2is built withBuildRequires: golang < 1.25, so its binaries carry unfixed Go standard-library CVEs. This drops theBuildRequires: golang < 1.25pin to rebuild with the default Go toolchain (1.26.x), and setsGOEXPERIMENT=ms_nocgo_opensslcryptoso theCGO_ENABLED=0build works with the new toolchain's OpenSSL backend.Change Log
BuildRequires: golang < 1.25-> build with the default Go toolchain (1.26.x).GOEXPERIMENT=ms_nocgo_opensslcryptoin%build/%check(Go 1.26 bridge; remove at Go 1.27).Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology