fix: populate output field in all error ToolResults for AI visibility#7
Merged
fix: populate output field in all error ToolResults for AI visibility#7
Conversation
ToolResult.output is the primary channel the AI reads. When only
error={"message": ...} was set, error details were invisible to the AI agent.
This adds output=error_msg alongside error={"message": error_msg} for all
error return paths (11 instances across grep.py, glob.py).
Same class of bug fixed in amplifier-bundle-lsp PR #3.
🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)
Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output=error_msgalongsideerror={"message": error_msg}for all 11 error return paths acrossgrep.pyandglob.pyToolResult.outputis the primary channel the AI reads — when onlyerror={"message": ...}was set, error details were invisible to the AI agentContext
Same class of bug fixed in amplifier-bundle-lsp PR #3. The pattern applied uniformly:
Test plan
python_checkclean across both files (ruff format, ruff lint, pyright)output=parameter to existing returns🤖 Generated with Amplifier