Repository navigation
Python: Correct Cosmos memory guide state scoping - #9443
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoOct 16, 2026
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only corrections match existing behavior, with no unresolved findings.
0 open findings
What changed in this PR
Corrects the Cosmos memory package guide to match the existing provider-scoped state contract. Runtime code and APIs are unchanged.
Changes:
- Shows how to set a stable user ID under
provider.source_id. - Removes the unsupported promise of a missing-user warning.
| File | Description |
|---|---|
python/packages/azure-cosmos-memory/AGENTS.md |
Corrects user ID scoping and fallback documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The Cosmos memory package guide places a stable user ID in flat session state, but the provider receives state scoped by its source ID. Following that entry therefore falls back to the session ID instead of the intended stable user ID.
Description & Review Guide
session.state.setdefault(provider.source_id, {})["user_id"], matching the existing README and three samples. Remove the missing-user warning promise, which the resolver does not implement.before_runandafter_run.Validation: eight controlled Core
Agent.runcalls check two provider IDs, flat versus scoped state, and two independent sessions. Four flat-state runs omituser_idfrom the delivered provider state; four scoped-state runs deliver the stable ID. The second session in each case uses the public session snapshot round trip. The Cosmos resolver was checked in source; no Cosmos/Foundry backend, live model, full package suite or build was run.Related Issue
N/A - trivial change. This corrects one guide entry to match the unchanged public contract already shown in the README, samples and resolver; the desired documentation result does not require a new design or behavior decision.
AI Assistance
AI assistance details: Documentation, validation, and PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.