.NET: Decouple Checkpointing from Run/StreamAsync APIs#4037
Draft
.NET: Decouple Checkpointing from Run/StreamAsync APIs#4037
Conversation
* Adds annotations to Declarative workflow executors
* Implicit filter in collection loops * Remove debug / usused / superfluous code * Fix ProtocolBuilder implicit output registrations * Fix logic error in ExecuteRouteGeneratorTests.ClassWithManualConfigureProtocol_DoesNotGenerate
…ecutor * Fixes an issue where ConcurrentEndExecutor is not expecting TurnTokens.
* Updates Declarative pacakge to rely on chained-delegation Send/Yield registration * Renames DeclarativeActionExectuor's new ExecuteAsync to ExecuteActionAsync to avoid colliding with Executor.ExecutoeAsync
With this change, Checkpointing becomes an property of an IWorkflowExecutionEnvironment. This lets environments that are tightly-coupled to their CheckpointManager avoid needing to present APIs that would not work (e.g. taking in an InMemory CheckpointManager for Durable Tasks, for example)
lokitoth
added
workflows
github-actions
bot
changed the title
lokitoth
had a problem deploying
to
integration
GitHub Actions
Failure
lokitoth
had a problem deploying
to
integration
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To support execution environments that do not support bring-your-own Checkpointing, we need to remove the ability to introduce
CheckpointManagerduring aRunAsync/StreamAsynccall.Description
Change Checkpointing to be a configuration of
IWorkflowExecutionEnvironmentintrinsically. This changes how checkpointing is configured forInProcessExecutionEnvironment(now usingWithCheckpointing)BREAKING: Changes how Checkpointing is attached for InMemory execution.
Currently in draft form pending #3792
Contribution Checklist