[2.0-stable] Cherry-pick: Fix AppInstance process handle validation (#6733) - #6735
Open
Scott Jones (Scottj1s) wants to merge 5 commits into
Open
[2.0-stable] Cherry-pick: Fix AppInstance process handle validation (#6733)#6735Scott Jones (Scottj1s) wants to merge 5 commits into
Scott Jones (Scottj1s) wants to merge 5 commits into
Conversation
Open non-current processes with SYNCHRONIZE once and transfer the validated handle into AppInstance before registering the termination wait. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: adb671f1-8cb1-4291-b25e-983d17a5bb1a
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks #6733 to
release/2.0-stable.Non-current
AppInstanceentries now open the process once withSYNCHRONIZE, discard stale entries when that open fails, and transfer the validated handle intoAppInstancefor wait registration.The new behavior is guarded by runtime compatibility change
AppLifecycle_GetInstancesProcessHandleFix(63876312). Disabling the change preserves the previous process-query and wait-registration behavior.Validation
The original source commits are patch-equivalent to the reviewed commits in #6733. The additional normalization commit corrects a line-ending artifact introduced while cherry-picking into the CRLF servicing source file.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.