Skip to content

Remove wizard logic for .wapproj templates (Review #6606 first)#6608

Draft
lauren-ciha wants to merge 10 commits into
mainfrom
user/laurenciha/clean-up-vsix-wizard
Draft

Remove wizard logic for .wapproj templates (Review #6606 first)#6608
lauren-ciha wants to merge 10 commits into
mainfrom
user/laurenciha/clean-up-vsix-wizard

Conversation

@lauren-ciha

@lauren-ciha lauren-ciha commented Jul 10, 2026

Copy link
Copy Markdown
Member

After the removal of the wapproj templates (#6606), some sections of the VSIX NuGetPackageInstaller wizard are no longer needed, namely:

  • The OnSolutionRestore event handlers
  • The OnSolutionRestore debouncing logic
  • Strings that were specific to the wait dialogs (the C++ template NuGet packages are added when the project is created, not after the VS window opens)

Validation:

  • Built locally with .\dev\Templates\VSIX\build-local-VSIX-package\build-install-localdev-vsix.ps1
  • Instantiated, built, and deployed (as applicable) the remaining project templates to confirm no regressions

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@lauren-ciha lauren-ciha changed the title User/laurenciha/clean up vsix wizard Remove code in WizardImplementation.cs that's not needed after .wapproj template removal Jul 10, 2026
@lauren-ciha lauren-ciha changed the title Remove code in WizardImplementation.cs that's not needed after .wapproj template removal Remove wizard logic for .wapproj templates (Review #6606 first) Jul 10, 2026
@lauren-ciha lauren-ciha requested review from DinahK-2SO and Copilot and removed request for Copilot July 10, 2026 17:00
Copilot AI reviewed Jul 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the Windows App SDK VSIX templates after the removal of the .wapproj-based “PackagedApp” templates by deleting now-obsolete template assets and simplifying the VSIX NuGet wizard implementation (removing solution-restore event handling, debouncing, and wait-dialog strings/UI).

Changes:

  • Removes the .wapproj-based PackagedApp template projects (C# + C++/WinRT) and all VSIX references to them (solution, manifests, project references).
  • Simplifies NuGetPackageInstaller by removing OnSolutionRestoreFinished-based flow and wait dialog logic; package installation proceeds directly for VC++ projects.
  • Removes now-unused localized strings (1044/1045) and their generated VSPackage.Designer.cs accessors for both C# and C++ extensions.

Reviewed changes

Copilot reviewed 72 out of 101 changed files in this pull request and generated no comments.

Show a summary per file
File Description
dev/Templates/VSIX/WindowsAppSDK.Extension.sln Drops PackagedApp wrapper projects from the VSIX build solution.
dev/Templates/VSIX/Shared/WizardImplementation.cs Removes solution-restore/wait-dialog logic from NuGet wizard; keeps direct install path.
dev/Templates/VSIX/Extension/Cs/Dev17/Standalone/source.extension.vsixmanifest Removes PackagedApp project template asset from C# Standalone VSIX.
dev/Templates/VSIX/Extension/Cs/Dev17/LocalDev/source.extension.vsixmanifest Removes PackagedApp project template asset from C# LocalDev VSIX.
dev/Templates/VSIX/Extension/Cs/Dev17/Component/source.extension.vsixmanifest Removes PackagedApp project template asset from C# Component VSIX.
dev/Templates/VSIX/Extension/Cs/Common/VSPackage.resx Removes wait-dialog string resources (1044/1045) for C# extension.
dev/Templates/VSIX/Extension/Cs/Common/VSPackage.Designer.cs Removes generated accessors for deleted resources (1044/1045) for C# extension.
dev/Templates/VSIX/Extension/Cs/Common/zh-TW/VSPackage.zh-TW.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/zh-CN/VSPackage.zh-CN.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/tr-TR/VSPackage.tr-TR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/ru-RU/VSPackage.ru-RU.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/pt-BR/VSPackage.pt-BR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/pl-PL/VSPackage.pl-PL.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/ko-KR/VSPackage.ko-KR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/ja-JP/VSPackage.ja-JP.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/it-IT/VSPackage.it-IT.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/fr-FR/VSPackage.fr-FR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/es-ES/VSPackage.es-ES.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/de-DE/VSPackage.de-DE.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cs/Common/cs-CZ/VSPackage.cs-CZ.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Dev17/WindowsAppSDK.Cpp.Extension.Dev17.csproj Removes PackagedApp wrapper template project reference from C++ VSIX.
dev/Templates/VSIX/Extension/Cpp/Dev17/Standalone/source.extension.vsixmanifest Removes PackagedApp project template asset and reflows formatting.
dev/Templates/VSIX/Extension/Cpp/Dev17/LocalDev/source.extension.vsixmanifest Removes PackagedApp project template asset and reflows formatting.
dev/Templates/VSIX/Extension/Cpp/Dev17/Component/source.extension.vsixmanifest Removes PackagedApp project template asset and reflows formatting.
dev/Templates/VSIX/Extension/Cpp/Common/VSPackage.resx Removes wait-dialog string resources (1044/1045) for C++ extension.
dev/Templates/VSIX/Extension/Cpp/Common/VSPackage.Designer.cs Removes generated accessors for deleted resources (1044/1045) for C++ extension.
dev/Templates/VSIX/Extension/Cpp/Common/zh-TW/VSPackage.zh-TW.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/zh-CN/VSPackage.zh-CN.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/tr-TR/VSPackage.tr-TR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/ru-RU/VSPackage.ru-RU.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/pt-BR/VSPackage.pt-BR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/pl-PL/VSPackage.pl-PL.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/ko-KR/VSPackage.ko-KR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/ja-JP/VSPackage.ja-JP.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/it-IT/VSPackage.it-IT.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/fr-FR/VSPackage.fr-FR.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/es-ES/VSPackage.es-ES.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/de-DE/VSPackage.de-DE.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/VSIX/Extension/Cpp/Common/cs-CZ/VSPackage.cs-CZ.resx Removes localized wait-dialog strings (1044/1045).
dev/Templates/templates.props Removes old VsixOnlyProjectTemplate instance; documents reserved slot usage.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/WinUI.Desktop.Cs.PackagedApp.vstemplate Deletes deprecated .wapproj-based C# PackagedApp template entrypoint.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/WinUI.Desktop.Cs.PackagedApp.csproj Deletes deprecated C# PackagedApp template wrapper project.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/WapProj/WinUI.Desktop.Cs.WapProj.vstemplate Deletes deprecated C# WapProj sub-template.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/WapProj/WapProjTemplate.wapproj Deletes deprecated C# WapProj project file.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/WapProj/Package-managed.appxmanifest Deletes deprecated C# WapProj appxmanifest.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/WinUI.Desktop.Cs.BlankApp.vstemplate Deletes deprecated C# BlankApp sub-template under PackagedApp.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/Properties/PublishProfiles/win-x86.pubxml Deletes deprecated publish profile asset.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/Properties/PublishProfiles/win-x64.pubxml Deletes deprecated publish profile asset.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/Properties/PublishProfiles/win-arm64.pubxml Deletes deprecated publish profile asset.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/ProjectTemplate.csproj Deletes deprecated C# PackagedApp project template .csproj.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/MainWindow.xaml.cs Deletes deprecated C# template source file.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/MainWindow.xaml Deletes deprecated C# template XAML.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/App.xaml.cs Deletes deprecated C# template source file.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/App.xaml Deletes deprecated C# template XAML.
dev/Templates/Source/ProjectTemplates/Desktop/CSharp/PackagedApp/BlankApp/app.manifest Deletes deprecated C# template app manifest.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/WinUI.Desktop.CppWinRT.PackagedApp.vstemplate Deletes deprecated .wapproj-based C++/WinRT PackagedApp template entrypoint.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/WinUI.Desktop.CppWinRT.PackagedApp.csproj Deletes deprecated C++/WinRT PackagedApp template wrapper project.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/WapProj/WinUI.Desktop.CppWinRT.WapProj.vstemplate Deletes deprecated C++/WinRT WapProj sub-template.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/WapProj/WapProjTemplate.wapproj Deletes deprecated C++/WinRT WapProj project file.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/WapProj/Package-managed.appxmanifest Deletes deprecated C++/WinRT WapProj appxmanifest.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/WinUI.Desktop.CppWinRT.BlankApp.vstemplate Deletes deprecated C++/WinRT BlankApp sub-template under PackagedApp.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/readme.txt Deletes deprecated template readme asset.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/ProjectTemplate.vcxproj.filters Deletes deprecated C++/WinRT template filters file.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/ProjectTemplate.vcxproj Deletes deprecated C++/WinRT template project file.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/pch.h Deletes deprecated C++/WinRT template PCH header.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/pch.cpp Deletes deprecated C++/WinRT template PCH source.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/MainWindow.xaml Deletes deprecated C++/WinRT template XAML.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/MainWindow.idl Deletes deprecated C++/WinRT template IDL.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/MainWindow.h Deletes deprecated C++/WinRT template header.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/MainWindow.cpp Deletes deprecated C++/WinRT template source.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/App.xaml Deletes deprecated C++/WinRT template App XAML.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/app.manifest Deletes deprecated C++/WinRT template app manifest.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/App.h Deletes deprecated C++/WinRT template App header.
dev/Templates/Source/ProjectTemplates/Desktop/CppWinRT/PackagedApp/BlankApp/App.cpp Deletes deprecated C++/WinRT template App source.
Files not reviewed (2)
  • dev/Templates/VSIX/Extension/Cpp/Common/VSPackage.Designer.cs: Generated file
  • dev/Templates/VSIX/Extension/Cs/Common/VSPackage.Designer.cs: Generated file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@DinahK-2SO DinahK-2SO Awaiting requested review from DinahK-2SO

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lauren-ciha