Fix Debug Failure crash when resolving overloaded decorators with explicit tuple rest parameters#63178
Open
hayatexe wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix Debug Failure crash when resolving overloaded decorators with explicit tuple rest parameters#63178hayatexe wants to merge 1 commit intomicrosoft:mainfrom
hayatexe wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…licit tuple rest parameters
Contributor
|
There is already an open PR fixing this: #63098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63094
Description
When utilizing
--experimentalDecoratorson methods or accessors, the compiler crashed with aDebug Failure. False expression.atgetArgumentArityErrorif a decorator had an explicitly typed tuple rest parameter (e.g....args: [any, any, any]) and an overload match failed.This happened because
getLegacyDecoratorArgumentCountincorrectly evaluatedsignature.parameters.lengthinstead ofgetParameterCount(signature)when deciding whether the decorator expects 2 or 3 parameters. Since the node length of a rest parameter is1(e.g.,...args), the function erroneously returned2, which bypassed some argument arity checks and later dropped intogetArgumentArityErrorwithargs.length = 3andmax = 3. This triggered a crash trying to getfirst()onargs.slice(3).This PR fixes the crash by using
getParameterCount(signature)withingetLegacyDecoratorArgumentCountto appropriately count effective parameters over rest arguments.A compiler test is included.