chore: update build_and_push script to get values from RG, update pos… - #1125
Open
NirajC3-Microsoft wants to merge 2 commits into
Open
chore: update build_and_push script to get values from RG, update pos…#1125NirajC3-Microsoft wants to merge 2 commits into
NirajC3-Microsoft wants to merge 2 commits into
Conversation
…t_deploy script to get missing values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request enhances the post-provisioning scripts for both PowerShell and Bash to support direct Azure resource discovery using a resource group argument, improves cross-platform compatibility, and adds logic to reconstruct AI Foundry resource values using naming conventions. These changes make the scripts more robust and flexible, reducing reliance on environment files and increasing their ability to recover missing configuration values.
Resource discovery and configuration:
Build-And-Push-Images.ps1andbuild_and_push_images.shnow accept a resource group parameter (-ResourceGroupor positional argument), allowing the scripts to query Azure directly for ACR, Container Apps, and Web App resources if provided, rather than relying solely on environment files. [1] [2] [3] [4]Cross-platform and reliability improvements:
tr -d '\r') in Bash scripts to improve compatibility across environments (e.g., Git Bash on Windows). [1] [2] [3]AI Foundry resource reconstruction:
post_deploy.ps1andpost_deploy.shto reconstruct AI Foundry account and project endpoints using naming conventions (aif-<suffix>,proj-<suffix>) if not present in deployment outputs, increasing resilience to missing configuration. [1] [2] [3] [4]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information