Preserve sideload tool-call metadata#768
Draft
BrainSlugs83 wants to merge 1 commit into
Draft
Conversation
Read optional toolCallStart, toolCallEnd, and supportsToolCalling from sideloaded inference_model.json files and thread the values through catalog BYO ModelInfo synthesis so local ONNX models can surface structured tool calls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@BrainSlugs83 is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@BrainSlugs83 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sideloaded/BYO ONNX model tool-call metadata propagation. inference_model.json can now declare optional oolCallStart, oolCallEnd, and supportsToolCalling; unresolved local models synthesized in catalog Step 4 preserve those values in ModelInfo.
Root cause
Sideloaded models could not produce structured delta.tool_calls because their metadata was dropped before inference:
Fix
Validation
Commit: $commit
Built on Windows with:
powershell python .\build.py --build --skip_tests --skip_examples --skip_service --config RelWithDebInfo --parallel 4 --cmake_path 'C:\Program Files\Microsoft Visual Studio\18\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe' --ctest_path 'C:\Program Files\Microsoft Visual Studio\18\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\ctest.exe' --vcpkg_root 'C:\Program Files\Microsoft Visual Studio\18\Community\VC\vcpkg'Targeted unit tests passed on the committed tree:
powershell .\build\Windows\RelWithDebInfo\bin\RelWithDebInfo\foundry_local_tests.exe --gtest_filter='LocalModelScannerTest.*:StaticCatalogClientTest.BYOModel_SynthesizedWhenNotInSnapshot'Result: 13 tests passed.