Skip to content

Resolve C5291 warning on ARM64 - #687

Merged
Chuck Walbourn (walbourn) merged 1 commit into
mainfrom
arm64warn
Nov 3, 2026
Merged

Chuck Walbourn (walbourn) merged 1 commit into
mainfrom
arm64warn

Conversation

@walbourn

Copy link
Copy Markdown
Collaborator

x64 builds default to /Wp16 while ARM64 builds default to /Wp8, so this warning was added to highlight a potential problem in layout differences. The this PR adds the recommended padding to silence the warning.

EffectCommon.h(85): warning C5291: 'DirectX::EffectLights': deriving from the base class 'DirectX::EffectColor' can cause potential runtime issues due to an ABI bug. Recommend adding a 8-byte data member to the base class for the padding at the end of it to work around this bug.'

AlphaTestEffect.cpp(41): warning C5291: 'DirectX::DX11::AlphaTestEffect::Impl': deriving from the base class 'DirectX::EffectBase<`anonymous-namespace'::AlphaTestEffectTraits>' can cause potential runtime issues due to an ABI bug. Recommend adding a 8-byte data member to the base class for the padding at the end of it to work around this bug.

@walbourn
Chuck Walbourn (walbourn) merged commit cb0e551 into main Nov 3, 2026
152 checks passed
@walbourn
Chuck Walbourn (walbourn) deleted the arm64warn branch November 3, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm64 Related to Windows on ARM64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants