[SM6.10][Bugfix] Update Matrix::Cast definition to switch matrix sizes on transpose#8368
Open
hekota wants to merge 1 commit intomicrosoft:mainfrom
Open
[SM6.10][Bugfix] Update Matrix::Cast definition to switch matrix sizes on transpose#8368hekota wants to merge 1 commit intomicrosoft:mainfrom
hekota wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…on transpose Spec updated in microsoft/hlsl-specs#842
Contributor
You can test this locally with the following command:git-clang-format --diff 5f8d05f9b760ae2be0242cad8ed719d10058b98c ff78a7324c74027b971dd3e4819ac8f1c713bec0 -- tools/clang/lib/Headers/hlsl/dx/linalg.hView the diff from clang-format here.diff --git a/tools/clang/lib/Headers/hlsl/dx/linalg.h b/tools/clang/lib/Headers/hlsl/dx/linalg.h
index b5a3c3fe..13557111 100644
--- a/tools/clang/lib/Headers/hlsl/dx/linalg.h
+++ b/tools/clang/lib/Headers/hlsl/dx/linalg.h
@@ -256,7 +256,8 @@ class Matrix {
__detail::DimMN<M, N, Transpose>::N, NewUse, Scope>
Cast() {
Matrix<NewCompTy, __detail::DimMN<M, N, Transpose>::M,
- __detail::DimMN<M, N, Transpose>::N, NewUse, Scope> Result;
+ __detail::DimMN<M, N, Transpose>::N, NewUse, Scope>
+ Result;
__builtin_LinAlg_CopyConvertMatrix(Result.__handle, __handle, Transpose);
return Result;
}
|
jenatali
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec updated in microsoft/hlsl-specs#842