[SM6.10] LinAlg: Fix thread-scope InterlockedAccumulate params#8367
Open
tex3d wants to merge 1 commit intomicrosoft:mainfrom
Open
[SM6.10] LinAlg: Fix thread-scope InterlockedAccumulate params#8367tex3d wants to merge 1 commit intomicrosoft:mainfrom
tex3d wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The thread-scope overload wasn't supposed to have Stride and Layout, since the Layout must be OuterProductOptimal for thread scope. Additionally, Align is device-dependent for OuterProductOptimal, so there's no point supplying it from HLSL or DXIL. This change removes these three parameters from this function in the HLSL Header, supplying 0 for Stride, MatrixLayout::OuterProductOptimal for Layout, and 0 for Align to the builtin operation which will pass these values along to the DXIL operation. Fixes microsoft#8360
jenatali
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread-scope overload wasn't supposed to have Stride and Layout, since the Layout must be OuterProductOptimal for thread scope.
Additionally, Align is device-dependent for OuterProductOptimal, so there's no point supplying it from HLSL or DXIL.
This change removes these three parameters from this function in the HLSL Header, supplying 0 for Stride, MatrixLayout::OuterProductOptimal for Layout, and 0 for Align to the builtin operation which will pass these values along to the DXIL operation.
Fixes #8360