Skip to content

[SM6.10][Exec] Don't used signed types for unsigned values#8364

Merged
V-FEXrt merged 5 commits intomicrosoft:mainfrom
V-FEXrt:linalg-hlk-signed
Apr 10, 2026
Merged

[SM6.10][Exec] Don't used signed types for unsigned values#8364
V-FEXrt merged 5 commits intomicrosoft:mainfrom
V-FEXrt:linalg-hlk-signed

Conversation

@V-FEXrt
Copy link
Copy Markdown
Collaborator

@V-FEXrt V-FEXrt commented Apr 10, 2026

Comparing int32_t for M/N to size_t caused failures on internal pipelines ala #8336

Since M/N don't make sense as negative values remove the entire class of errors by changing them to unsigned types.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff a5877b6bcd333cf742c2840cdd494e5b02f11cf6 d4676f9a497edaab04ee85c73c8d71178c2ef5f3 -- tools/clang/unittests/HLSLExec/LinAlgTests.cpp
View the diff from clang-format here.
diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 01fe9b6c..30edf8eb 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -229,8 +229,9 @@ static bool fillInputBuffer(LPCSTR Name, std::vector<BYTE> &Data,
   return false;
 }
 
-static VariantCompType makeExpected(ComponentType CompType, MatrixDim M, MatrixDim N,
-                                    float StartingVal, bool Increment = true,
+static VariantCompType makeExpected(ComponentType CompType, MatrixDim M,
+                                    MatrixDim N, float StartingVal,
+                                    bool Increment = true,
                                     bool Transpose = false) {
   const size_t NumElements = M * N;
   std::vector<float> Floats(NumElements);
  • Check this box to apply formatting changes to this branch.

@V-FEXrt V-FEXrt merged commit f822151 into microsoft:main Apr 10, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 10, 2026
@V-FEXrt V-FEXrt deleted the linalg-hlk-signed branch April 10, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants