[SM6.10][Exec] Don't used signed types for unsigned values#8364
Merged
V-FEXrt merged 5 commits intomicrosoft:mainfrom Apr 10, 2026
Merged
[SM6.10][Exec] Don't used signed types for unsigned values#8364V-FEXrt merged 5 commits intomicrosoft:mainfrom
V-FEXrt merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
You can test this locally with the following command:git-clang-format --diff a5877b6bcd333cf742c2840cdd494e5b02f11cf6 d4676f9a497edaab04ee85c73c8d71178c2ef5f3 -- tools/clang/unittests/HLSLExec/LinAlgTests.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 01fe9b6c..30edf8eb 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -229,8 +229,9 @@ static bool fillInputBuffer(LPCSTR Name, std::vector<BYTE> &Data,
return false;
}
-static VariantCompType makeExpected(ComponentType CompType, MatrixDim M, MatrixDim N,
- float StartingVal, bool Increment = true,
+static VariantCompType makeExpected(ComponentType CompType, MatrixDim M,
+ MatrixDim N, float StartingVal,
+ bool Increment = true,
bool Transpose = false) {
const size_t NumElements = M * N;
std::vector<float> Floats(NumElements);
|
jenatali
approved these changes
Apr 10, 2026
tex3d
reviewed
Apr 10, 2026
tex3d
reviewed
Apr 10, 2026
tex3d
reviewed
Apr 10, 2026
Co-authored-by: Tex Riddell <texr@microsoft.com>
tex3d
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing
int32_tfor M/N tosize_tcaused failures on internal pipelines ala #8336Since M/N don't make sense as negative values remove the entire class of errors by changing them to unsigned types.