Skip to content

Align sandbox defaults with the cchost configuration schema - #8176

Open
Amaury Chamayou (achamayou) with Copilot wants to merge 14 commits into
mainfrom
copilot/clarify-default-configuration-options
Open

Align sandbox defaults with the cchost configuration schema#8176
Amaury Chamayou (achamayou) with Copilot wants to merge 14 commits into
mainfrom
copilot/clarify-default-configuration-options

Conversation

Copilot AI commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

The sandbox inherited test-optimized defaults from the e2e infrastructure, causing its generated configuration and CLI help to diverge from documented cchost defaults—for example, a 100ms rather than 1000ms signature delay.

  • Schema-backed defaults
    • Map CLI arguments to host configuration schema paths.
    • Derive defaults and descriptions from the schema, including unit conversion.
CLI_ARGUMENT_CONFIG_PATHS = {
    "sig_ms_interval": "ledger_signatures.delay",
    "snapshot_tx_interval": "snapshots.tx_count",
}
  • Sandbox behavior

    • Make sandbox.sh opt into schema defaults while preserving faster e2e defaults.
    • Remove wrapper-specific node configuration overrides.
    • Preserve explicit command-line values as the highest precedence.
  • Distribution and documentation

    • Install the host schema alongside the sandbox infrastructure.
    • Document the sandbox/e2e default distinction.

Copilot AI and others added 3 commits August 18, 2026 23:24
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot AI changed the title [WIP] Clarify default configuration options for the sandbox Align sandbox defaults with the cchost configuration schema Aug 18, 2026
@achamayou
Amaury Chamayou (achamayou) requested a balanced review from Copilot August 20, 2026 14:15
Comment thread doc/build_apps/run_app.rst Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns sandbox configuration defaults and CLI help with the cchost schema while retaining optimized e2e defaults.

Changes:

  • Adds schema-backed default resolution and unit conversion.
  • Enables schema defaults for sandbox.sh.
  • Adds documentation, installation support, and regression tests.

Custom instructions used

  • .github/copilot-instructions.md
  • .github/instructions/changelog.instructions.md

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/start_network.py Adds the schema-default opt-in flag.
tests/sandbox/sandbox.sh Enables schema defaults and removes overrides.
tests/infra/e2e_args.py Resolves defaults and descriptions from the schema.
tests/e2e_args_test.py Tests defaults, precedence, and diagnostics.
doc/build_apps/run_app.rst Documents sandbox default behavior.
CMakeLists.txt Installs the schema and registers tests.
CHANGELOG.md Records the user-facing change.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@achamayou
Amaury Chamayou (achamayou) marked this pull request as ready for review August 20, 2026 14:39
@achamayou
Amaury Chamayou (achamayou) requested a review from a team as a code owner August 20, 2026 14:39
@achamayou

Copy link
Copy Markdown
Member

Copilot resolve the merge conflicts in this pull request

…lt-configuration-options

# Conflicts:
#	CHANGELOG.md

Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Copilot resolve the merge conflicts in this pull request

Resolved the merge conflict with origin/main and pushed merge commit a808eaf53.

@achamayou Amaury Chamayou (achamayou) removed the run-long-test Run Long Test job label Aug 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread tests/infra/e2e_args.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify default configuration options for the sandbox

3 participants