Test recovery from snapshots produced with expired node certificates - #8175
Merged
Amaury Chamayou (achamayou) merged 10 commits intoAug 24, 2026
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test to check snapshots with expired node cert for recovery
Test recovery from snapshots produced with expired node certificates
Aug 18, 2026
Amaury Chamayou (achamayou)
approved these changes
Aug 19, 2026
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
August 19, 2026 07:11
View session
Amaury Chamayou (achamayou)
marked this pull request as ready for review
August 19, 2026 07:15
Amaury Chamayou (achamayou)
approved these changes
Aug 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a regression test to ensure service recovery accepts snapshots created after the issuing node’s TLS certificate has expired, and updates the recovery helper to support recovering from an explicit snapshots directory (preventing fallback to older snapshots/ledger replay).
Changes:
- Extend
test_recover_serviceto accept an explicitsnapshots_diroverride. - Add an end-to-end test that backdates a node cert to be expired, forces a committed snapshot, and recovers from that snapshot alone.
- Register the new recovery scenario in the test runner.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
Amaury Chamayou (achamayou) due to an error
August 19, 2026 07:31
Capture the isolated snapshot after the recovery requirement issues its tracked transactions, and scope temporary state and CA verification changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Skip historical range verification when shutting down the recovery network because this test intentionally provides no pre-snapshot ledger. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 66397969-1156-4f98-ac66-f9acef8dc11b
Eddy Ashton (eddyashton)
approved these changes
Aug 24, 2026
Amaury Chamayou (achamayou)
enabled auto-merge (squash)
August 24, 2026 13:53
Amaury Chamayou (achamayou)
deleted the
copilot/add-test-check-snapshots
branch
August 24, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery must accept snapshots produced after the issuing node's certificate expires. Existing coverage could fall back to an older snapshot or ledger replay.
Closes #6553