Add end-to-end coverage for large enclave responses - #8174
Add end-to-end coverage for large enclave responses#8174Amaury Chamayou (achamayou) merged 13 commits into
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds end-to-end coverage for enclave-generated HTTP responses at/above the ringbuffer capacity, to complement existing KV stress tests and close #5039.
Changes:
- Added a new readonly, authenticated
/batch/generateendpoint that returns a response body of requested size. - Added an e2e test that requests 16 MiB and 32 MiB responses and verifies status, size, and boundary bytes before existing stress tests.
- Updated the “run to destruction” entrypoint logic to adjust
max_msg_size_bytesaround the new large-response coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e_batched.py | Adds large-response e2e test and updates max message size configuration around destruction runs. |
| src/apps/batched/src/batched.js | Adds response generator handler that returns a body of requested size. |
| src/apps/batched/app.json | Registers the new /batch/generate endpoint with authn/readonly/no-forwarding settings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Eddy Ashton (eddyashton)
left a comment
There was a problem hiding this comment.
I had pending comments on the test structure, but it looks like I never posted those and they're resolved now? LGTM.
Existing stress tests cover large requests and KV writes, but not enclave-generated responses near or above ringbuffer capacity.
Changes
memory.circuit_sizeandmemory.max_msg_sizefrom the active primary's rendered configuration.memory.max_msg_size, preserving headroom for QuickJS and response serialization.Closes #5039