Repository navigation
Fix flaky tests and remove checkAccessibility overrides - #5873
Merged
Eugene (OEvgeny) merged 4 commits intoOct 16, 2026
Merged
Conversation
added 3 commits
October 16, 2026 11:05
- pageObjects.scrollToTop(): react-scroll-to-bottom ignores scroll events right after its animation ends without updating the sizes it remembers. The next scroll is mistaken as a resize while sticky and it scrolls back to the bottom. Scroll again (up to 3 attempts), like a user would. Fixes scrollToEndButton.containerSize.html failing ~15-25% under load (40/40 after). - unknownAttachment.html: the live region renders the activity 5-15 ms after the transcript, wait for the console.warn before asserting.
Replacing window.checkAccessibility disabled accessibility checks for whole tests. With the checker running: - 11 tests had obsolete overrides (no violations in any variant), removed. part-grouping/keyboard, navigation and position never ran with a variant, the overrides were dead code. - Known violations are now skipped explicitly with skipCheckAccessibility, scoped to the failing variants and snapshots, with a TODO: - part-grouping/status and index (copilot): part grouping remounts when its first activity changes, aria-activedescendant points to the removed group. - side-by-side: the deprecated Copilot custom variant puts non-articles in role="feed"; contrast in the View code dialog. - markdown/vnext/markdownStreaming: bot markdown "# Heading" renders a level-one heading (#4721).
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Timing-sensitive scrolling and restored accessibility checks need browser-suite confirmation beyond the available static review.
0 open findings
What changed in this PR
Improves Web Chat’s browser-test reliability and restores accessibility checks previously disabled by global overrides.
Changes:
- Adds bounded scroll retries and waits for the live-region warning before asserting.
- Replaces global accessibility overrides with explicit skips for known failures.
- Moves two post-release fixes into the Unreleased changelog.
| File | Description |
|---|---|
| packages/test/page-object/src/globals/pageObjects/scrollToTop.js | Retries scrolling when the transcript snaps back. |
| CHANGELOG.md | Moves #5865 and #5872 fixes to Unreleased. |
| tests/html2/side-by-side/index.html | Scopes accessibility skips to affected variants and dialog snapshots. |
| tests/html2/part-grouping/status.html | Limits skips to affected Copilot snapshots. |
| tests/html2/part-grouping/position.html | Removes global accessibility override. |
| tests/html2/part-grouping/navigation.html | Removes global accessibility override. |
| tests/html2/part-grouping/keyboard.html | Removes global accessibility override. |
| tests/html2/part-grouping/index.html | Adds explicit Copilot accessibility skips. |
| tests/html2/part-grouping/folded.skip.html | Removes override from the skipped test. |
| tests/html2/markdown/vnext/markdownStreaming.html | Explicitly skips checks for the known heading violation. |
| tests/html2/fluentTheme/focusBack.multiple.html | Removes override while retaining the existing skip. |
| tests/html2/copyButton/layout.html | Restores accessibility checks. |
| tests/html2/citation/url.html | Restores accessibility checks. |
| tests/html2/citation/showModal.linkDefinitions.html | Restores accessibility checks. |
| tests/html2/citation/accordion.html | Restores accessibility checks. |
| tests/html2/activity/message-status.html | Restores accessibility checks. |
| tests/html2/activity/legacy/unknownAttachment.html | Waits for the warning before asserting. |
| tests/html2/activity/collapsible.html | Restores accessibility checks. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
William Wong (compulim)
previously approved these changes
Oct 16, 2026
William Wong (compulim)
left a comment
William Wong (compulim)
left a comment
Collaborator
There was a problem hiding this comment.
Nitpicking.
- unknownAttachment.html: wait with @testduet/wait-for and expect. - scrollToTop(): clarify why scrolling again is needed, add a TODO to remove the retry after compulim/react-scroll-to-bottom#145 is released.
Eugene (OEvgeny)
dismissed
William Wong (compulim)’s stale review
via
October 16, 2026 20:34
688f8e7
William Wong (compulim)
approved these changes
Oct 16, 2026
Eugene (OEvgeny)
enabled auto-merge (squash)
October 16, 2026 21:10
Eugene (OEvgeny)
deleted the
OEvgeny/fix-flaky-tests-and-axe-overrides
branch
October 16, 2026 21:18
1 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Not required, development only.
Description
Fixes 2 flaky tests and removes
window.checkAccessibility = async () => {}from tests, which disabled the accessibility check for the whole test. Remaining known violations are skipped explicitly withskipCheckAccessibility, scoped to the failing variants and snapshots, with a TODO.Design
react-scroll-to-bottommay mistake the first scroll after its scroll animation as a resize while sticky, and scroll back to the bottom.pageObjects.scrollToTop()now scrolls again, like a user would.Specific Changes
pageObjects.scrollToTop(): scroll again when the transcript snaps back to the bottom, fixes flakyscrollToEndButton.containerSize.htmlactivity/legacy/unknownAttachment.html: wait for the live region warning before assertingRemoved obsolete
window.checkAccessibilityoverrides from 11 testsReplaced the remaining overrides with
skipCheckAccessibilityand a TODO:part-grouping/status.html,part-grouping/index.html: part grouping remounts when its first activity changes,aria-activedescendantpoints to the removed groupside-by-side/index.html: deprecated Copilot custom variant puts elements other than articles inrole="feed"; color contrast in the "View code" dialogmarkdown/vnext/markdownStreaming.html: markdown#renders a level-one headingCHANGELOG.md: moved fix: prevent message actions from repeating bot responses #5865 and Show Copy confirmation for 5 seconds and keep focus indicator visible… #5872 entries from 4.19.2 to Unreleased, they were merged after the releaseI have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed