Bug 651757: [Repair Item] [Manufacturing] Warehouse Pick is not generated for Make-to-Order subassembly after registered put-away

[Chethan Thopaiah (ChethanT)]

Issue

In a make-to-order production structure, a component can be supplied by another production-order line, such as a subassembly that is produced and put away before being picked for its parent assembly.

The production order's Completely Picked FlowField excluded components with a nonzero Supplied-by Line No.. The order could therefore be considered completely picked while the supplied subassembly was still unpicked. Warehouse registration then marked the production pick request complete, preventing the required follow-up warehouse pick from being generated.

Fix rationale

Calculate Completely Picked across all production-order components, including supplied-by components. A production order should be completely picked only when every required component has been picked.

This keeps the warehouse pick request open while a supplied subassembly remains unpicked, allowing the follow-up pick to be generated. Once the supplied component is picked, the production order can correctly become completely picked.

Summary

• include supplied-by production components when calculating whether a production order is completely picked
• add regression coverage for fully picked supplied components and mixed picked/unpicked components

Validation

• pre-fix RED: both focused codeunit 137069 procedures failed with the incorrect opposite results
• post-fix GREEN: both focused procedures passed on Business Central 30.0
• Base Application and Tests-SCM-Manufacturing compiled successfully
• git diff --check passed

AB#651757

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change includes supplied-by production components in the production order's Completely Picked calculation. An unpicked make-to-order subassembly therefore keeps the order and its warehouse pick request incomplete, so the follow-up pick can be generated after put-away.

The removed filter addresses the root cause directly. The warehouse registration path reads this aggregate before marking production pick requests complete, and the component update logic maintains the picked state used by the aggregate. The tests cover both a picked supplied component and a mixed order with an unpicked supplied component.

Problem-solution fit

Fit: Strong

The change matches the reported failure: a required supplied component can no longer be ignored when deciding that all production picking is complete. The scope is limited to the completion calculation and focused regression coverage.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: The FlowField value changes for every caller when supplied-by components exist, including production pick creation and warehouse registration. The component-level picked state and the surrounding request logic are consistent with the new aggregate, and no public signature or schema changes are introduced.

Necessity: The change is required because the previous filter could close the warehouse pick request while a required subassembly was still unpicked. Without the fix, the follow-up warehouse pick cannot be generated in the reported make-to-order flow.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=12068 round=1 by=alexei-dobriansky at=2026-09-29T18:29:33.7417480Z lastSha=182e12f62caa6c666e67a1e02f1905153aefb585 reviewKey=a7e9eb1ba0a292b02a11413ab27b5a9a0f068f6a29e6f1fb6003504389ba7be4 suggestions=none