Fix Norwegian SAF-T 1.30 export issues - #11629
Aleksandr Gladkov (AleksanderGladkov) wants to merge 1 commit into
Conversation
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThis updates the Norwegian SAF-T 1.30 exporter to write the 1.30 header version, use the running application version, export foreign-currency credit amounts as positive values, suppress unselected dimensions, and count exported transaction groups. The header, currency, and dimension changes are targeted, and the version branch keeps the 1.20 count path unchanged. The transaction-count change still calculates one count from the full export header period, so split G/L files can still write a value that does not match the Problem-solution fitFit: Partial The change addresses the header, amount, and analysis parts of the reported problem. It only partly addresses the split-file entry-count problem because the count is still stored once for the whole selected period and then repeated in each G/L file. SuggestionsS1 (🔴 High): Count split files per exported period Risk assessment and necessityRisk: This is a tax/audit XML export, so a wrong Necessity: The fix is needed because the affected export can publish wrong header, amount, analysis, and transaction-count data. The scope is appropriate for a bug fix, but the split-file count must match the contents of each generated file before the change is safe to merge.
|
ISSUE:
Norwegian SAF-T 1.30 exports can contain wrong header versions, negative credit amounts, unwanted dimensions and inconsistent transaction totals.
CAUSE:
The header versions were hardcoded. Credit currency amounts retained their sign, excluded dimensions could produce XML nodes, and the transaction count used G/L transaction numbers instead of exported transaction groups.
SOLUTION:
TESTS:
Added XML regression coverage for header versions, customer/vendor/bank currencies, dimension selection and transaction totals in single and split files.
Fixes AB#650030