[29.x] Multiple runs of email retrieval on the same emails don't persist again - #11624
Open
Joshua (mynjj) wants to merge 1 commit into
Open
Joshua (mynjj) wants to merge 1 commit into
Joshua (mynjj) wants to merge 1 commit into
Conversation
dcenic
approved these changes
Sep 18, 2026
Aleksandr Gladkov (AleksanderGladkov)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11612.
Fix at the email module layer of the bug causing additional entries to be persisted when retrieving the same email.
If the email had already been retrieved and stored, then such email is returned without further persisting, unless the previous email was stored without attachments, in which case only the attachment is added to such email message.
Tested the behavior against my email inbox locally.
Fix overview
FindRetrievedEmailon the email module, with the idea of centralizing this potentially tricky logic and benefitting other connectors.AddAttachmentwas needed, since theModifyon the email message that was run after, triggers a subscriber that errors when modifying a received email (rationale of the error is that the system shouldn't modify emails after they have been received, but in this scenario we are not modifying the EmailMessage, but rather adding an attachment and leaving the message as it was, so we don't want this validation to run)Fixes AB#650461