[29.0] Clarify Expense Agent and expense management setup - #11614
Prangshuman Das (t-prda) wants to merge 1 commit into
Conversation
Backport #11541 for AB#650545. Adapt only newly introduced CLEAN30 guards and ObsoleteTag 30.0 properties to CLEAN29 and 29.0; retain release-specific Entra application handling and telemetry ID 0000VGO. (cherry picked from commit 9f382f6) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7a535d01-fbef-4fb8-b5e9-ad0c29f2921c Copilot-Session: 2c31d71b-4326-483a-9a7e-800a8391563b
Good Sense Reviewer - Round 1Recommendation: Accept with SuggestionsWhat this PR doesThis release backport moves agent-specific setup guidance into the Configure Expense Agent wizard and leaves the setup page focused on expense-management settings. The main flow is coherent: activation settings are hidden from the general setup page, stale mailbox selections are repaired in the wizard, and service registration now receives an explicit endpoint choice. Two edge cases still need cleanup so users are not guided back to the old setup name and deactivation unregisters the correct service endpoint. Problem-solution fitFit: Partial The reported problem is mostly addressed because users no longer see the agent activation fields on the general setup page and the wizard owns those settings. The fit is not complete while one navigation entry can still expose the old setup wording, and while a same-save endpoint change can make deactivation clean up the wrong service registration. SuggestionsS1 (🟠 Moderate): Old navigation caption remains searchable S2 (🟠 Moderate): Disable can unregister the wrong endpoint Risk assessment and necessityRisk: The changed area is setup UI, scheduled Expense Agent communication, and service registration. It does not touch posting, ledger entries, or BaseApp event publishers, so the main regression risk is users configuring the wrong surface or a tenant leaving a stale service registration after a canary endpoint change. The current CI checks are green, and no local build or runtime test was run for this review. Necessity: The change is needed because users can otherwise land on a read-only agent setup surface without a clear path to configure the agent. The scope is appropriate for a release backport, provided the remaining navigation and endpoint cleanup edges are fixed.
|
What & why
Backport merged #11541 to
releases/29.0for the Expense Agent configuration navigation and setup clarification. Applied the single authoritative squash commit9f382f608fab7e117cfeb1e33fa9f70259386bfa, preserving its behavior across the same five AL files.The only release adaptation changes the seven newly introduced
CLEAN30guards toCLEAN29and twenty newly introducedObsoleteTag = '30.0'properties to29.0. Existing release-specific Entra application handling, unrelated obsoletions/guards, object identities, and app manifest/runtime versions remain unchanged. Retains generated telemetry ID0000VGO.Linked work
Fixes AB#650545
29.0 backport work item AB#650545
Source: #11541 and AB#640269 (informational provenance only; this PR resolves the release-specific work item above).
How I validated this
What I tested and the outcome
git diff --check, exact five-file scope, absence of conflict markers, exact source added/deleted-line comparison before adaptation, and exact comparison confirming that only the seven new cleanup guards and twenty new obsoletion tags changed for this release.0000VGO.8527b3c05a67677d7fedb30c3301b2ac355970e4and the worktree is clean.Risk & compatibility
Public page controls remain Pending until
CLEAN29cleanup. This preserves the source change's setup/UI behavior, staged mailbox repair, explicit selected endpoint behavior on Update, and missing-setup diagnostic. Existing release-specific Entra application handling is preserved. No access consolidation, scheduler guards, explicit-clear toggle follow-up, unrelated fixes, new tests, or future main-branch alignment are included. No merge or auto-merge is requested.