Skip to content

[29.0] Clarify Expense Agent and expense management setup - #11614

Open
Prangshuman Das (t-prda) wants to merge 1 commit into
releases/29.0from
t-prda-backport-650545-expense-setup-290
Open

Prangshuman Das (t-prda) wants to merge 1 commit into
releases/29.0from
t-prda-backport-650545-expense-setup-290

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

What & why

Backport merged #11541 to releases/29.0 for the Expense Agent configuration navigation and setup clarification. Applied the single authoritative squash commit 9f382f608fab7e117cfeb1e33fa9f70259386bfa, preserving its behavior across the same five AL files.

The only release adaptation changes the seven newly introduced CLEAN30 guards to CLEAN29 and twenty newly introduced ObsoleteTag = '30.0' properties to 29.0. Existing release-specific Entra application handling, unrelated obsoletions/guards, object identities, and app manifest/runtime versions remain unchanged. Retains generated telemetry ID 0000VGO.

Linked work

Fixes AB#650545

29.0 backport work item AB#650545

Source: #11541 and AB#640269 (informational provenance only; this PR resolves the release-specific work item above).

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

  • Source/git correctness checks only: git diff --check, exact five-file scope, absence of conflict markers, exact source added/deleted-line comparison before adaptation, and exact comparison confirming that only the seven new cleanup guards and twenty new obsoletion tags changed for this release.
  • Confirmed explicit Canary argument propagation at the registration/unregistration call sites and retained telemetry ID 0000VGO.
  • Verified pushed remote head matches local commit 8527b3c05a67677d7fedb30c3301b2ac355970e4 and the worktree is clean.
  • Local builds, analyzer execution, automated/runtime tests, publishing, and NST/environment operations were explicitly waived by the user and were not performed. No new tests added, per the requested straight-backport scope. Build and test validation is CI-only and remains pending; the source PR's local validation is not claimed as validation of this release branch.

Risk & compatibility

Public page controls remain Pending until CLEAN29 cleanup. This preserves the source change's setup/UI behavior, staged mailbox repair, explicit selected endpoint behavior on Update, and missing-setup diagnostic. Existing release-specific Entra application handling is preserved. No access consolidation, scheduler guards, explicit-clear toggle follow-up, unrelated fixes, new tests, or future main-branch alignment are included. No merge or auto-merge is requested.

Backport #11541 for AB#650545. Adapt only newly introduced CLEAN30 guards and ObsoleteTag 30.0 properties to CLEAN29 and 29.0; retain release-specific Entra application handling and telemetry ID 0000VGO.

(cherry picked from commit 9f382f6)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7a535d01-fbef-4fb8-b5e9-ad0c29f2921c
Copilot-Session: 2c31d71b-4326-483a-9a7e-800a8391563b
@t-prda
Prangshuman Das (t-prda) requested a review from a team as a code owner September 18, 2026 13:52
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 18, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Sep 18, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

This release backport moves agent-specific setup guidance into the Configure Expense Agent wizard and leaves the setup page focused on expense-management settings. The main flow is coherent: activation settings are hidden from the general setup page, stale mailbox selections are repaired in the wizard, and service registration now receives an explicit endpoint choice. Two edge cases still need cleanup so users are not guided back to the old setup name and deactivation unregisters the correct service endpoint.

Problem-solution fit

Fit: Partial

The reported problem is mostly addressed because users no longer see the agent activation fields on the general setup page and the wizard owns those settings. The fit is not complete while one navigation entry can still expose the old setup wording, and while a same-save endpoint change can make deactivation clean up the wrong service registration.

Suggestions

S1 (🟠 Moderate): Old navigation caption remains searchable
The page caption now says Expense Management Setup, but the role center action that opens this page still says Expense Agent Setup. Rename that action and tooltip, or users can still find and open the old entry from Tell Me and stay confused.

S2 (🟠 Moderate): Disable can unregister the wrong endpoint
When the user changes the canary toggle and disables the agent in the same Update, this call uses the new endpoint. Unregister the endpoint that was active before the change, otherwise the old service registration can be left behind.

Risk assessment and necessity

Risk: The changed area is setup UI, scheduled Expense Agent communication, and service registration. It does not touch posting, ledger entries, or BaseApp event publishers, so the main regression risk is users configuring the wrong surface or a tenant leaving a stale service registration after a canary endpoint change. The current CI checks are green, and no local build or runtime test was run for this review.

Necessity: The change is needed because users can otherwise land on a read-only agent setup surface without a clear path to configure the agent. The scope is appropriate for a release backport, provided the remaining navigation and endpoint cleanup edges are fixed.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11614 round=1 by=alexei-dobriansky at=2026-09-18T19:14:35Z lastSha=8527b3c05a67677d7fedb30c3301b2ac355970e4 reviewKey=92fdf358c105017496255479f8aff954a09952d3f10bf21437631edecc5b22c3 suggestions=S1@f833b1ce,S2@c9b79c4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants