Security: require Stripe webhook signature, blog admin override#534
Merged
Security: require Stripe webhook signature, blog admin override#534
Conversation
1. Stripe webhook: reject if STRIPE_WEBHOOK_SECRET not configured instead of silently accepting unsigned events. Prevents forged webhook events from crediting arbitrary accounts. 2. Blog edit/delete: add admin override (&&!acc.Admin) matching the pattern used by apps and social. Admins can now moderate blog posts. https://claude.ai/code/session_01GRGLA9yj7BpqKiyi6xFwnm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit Fixes
1. Stripe webhook signature now REQUIRED (HIGH)
Previously if
STRIPE_WEBHOOK_SECRETwasn't set, webhooks were accepted without verification. An attacker could forge events to credit any account. Now rejects with 503 if secret isn't configured.2. Blog edit/delete admin override (MEDIUM)
Blog post edit and delete only checked author ownership. Unlike apps (
&& !acc.Admin) and social, admins couldn't moderate blog posts. Fixed to match the same pattern.Audit results (no action needed)
https://claude.ai/code/session_01GRGLA9yj7BpqKiyi6xFwnm