Config serializer#2982
Open
ripplebiz wants to merge 8 commits into
Open
Conversation
* new prefs file now "/prefs.json"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config for Companion, Repeater and Room server migrated to a simple JSON representation.
To keep the impact minimal, the same member variable access is used by modules using the prefs structures. Just the storage is affected at this stage.
The prefs now group related properties into sub objects: "gps", "radio", "bridge", "power"
Prefs related to repeating packets are in "repeat" sub object
Room server related in "room"
Companion related prefs in "comp"
Some common top-level properties are: "name", "lat", "lon"
A subsequent step/PR could be to refactor all the accesses of prefs, making a new common prefs classes with common components, lie gps, radio, etc
The new ConfigSerializer class makes declaring the JSON structures simple. It can handle the various scalar values, like integers, can handle C string values, and even nested objects. It cannot do JSON arrays, tho