enable cache_db auto compaction#158
Merged
Merged
Conversation
wiz
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the shared rocksdb store constructor disables auto compaction to speed up initial indexing:
electrs/src/new_index/db.rs
Line 312 in 5d39070
and then we have to explicitly re-enable it on each store instance later:
electrs/src/new_index/schema.rs
Lines 363 to 365 in 5d39070
electrs/src/new_index/schema.rs
Lines 373 to 375 in 5d39070
but when the cache_db was added in [2699560], apparently auto compaction was never re-enabled for that store.
this means
in normal operation this isn't very noticeable because the cache_db is small and rarely flushed, but if you did something silly like reboot electrs and re-run the precache every hour then read performance for less popular addresses could eventually become severely degraded.