Skip to content

MM-68258 Remove docs for secure_connection_manager role#8875

Open
wiggin77 wants to merge 1 commit intomasterfrom
MM-68258_remove_role_secure_connetion_manager
Open

MM-68258 Remove docs for secure_connection_manager role#8875
wiggin77 wants to merge 1 commit intomasterfrom
MM-68258_remove_role_secure_connetion_manager

Conversation

@wiggin77
Copy link
Copy Markdown
Member

Summary

Removes docs for secure_connection_manager role. This role was added recently, never shipped, and it was decided we do not need it.

Ticket Link

https://mattermost.atlassian.net/browse/MM-68258

@wiggin77 wiggin77 requested a review from BenCookie95 April 10, 2026 00:24
@wiggin77 wiggin77 added the 1: Dev Review Requires review by a core commiter label Apr 10, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1fb1cde1-3fed-4900-8306-ad494ce12f76

📥 Commits

Reviewing files that changed from the base of the PR and between 73e24f9 and 88a4709.

📒 Files selected for processing (3)
  • source/administration-guide/onboard/advanced-permissions-backend-infrastructure.rst
  • source/administration-guide/onboard/connected-workspaces.rst
  • source/administration-guide/onboard/delegated-granular-administration.rst
💤 Files with no reviewable changes (1)
  • source/administration-guide/onboard/advanced-permissions-backend-infrastructure.rst

📝 Walkthrough

Walkthrough

This pull request removes the system_secure_connection_manager role and its associated manage_secure_connections permission from documentation. It restricts connected workspace operations and secure connection management to system administrators only, removing prior delegation capabilities to users with the Secure Connection Manager role.

Changes

Cohort / File(s) Summary
Built-in role removal
source/administration-guide/onboard/advanced-permissions-backend-infrastructure.rst
Removes the system_secure_connection_manager role definition and its default manage_secure_connections permission entry from the "Built-in roles" section.
Connected workspace authorization updates
source/administration-guide/onboard/connected-workspaces.rst
Restricts secure connection creation from "system admins or Secure Connection Manager role users" to "system admins" only. Removes Secure Connection Manager delegation references from Slash Commands and the "Manage connections and invitations" section, limiting delegation to Shared Channel Manager.
Delegated administration configuration
source/administration-guide/onboard/delegated-granular-administration.rst
Removes Secure Connection Manager from the "Available roles" list and deletes corresponding default permissions table entries. Removes role assignment instructions and mmctl command examples. Updates the "Edit privileges of admin roles" section to exclude only Custom Group Manager and Shared Channel Manager from system admin grant restrictions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing documentation for the secure_connection_manager role.
Description check ✅ Passed The description is directly related to the changeset, explaining why the documentation is being removed (role was added recently, never shipped, and is no longer needed).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MM-68258_remove_role_secure_connetion_manager

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 88a4709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1: Dev Review Requires review by a core commiter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants