Skip to content

feat: migrate spaced themes to CSS variables and add interactive theme builder#1145

Merged
mathuo merged 1 commit intomasterfrom
moconnor/theme-builder-css-variables
Mar 29, 2026
Merged

feat: migrate spaced themes to CSS variables and add interactive theme builder#1145
mathuo merged 1 commit intomasterfrom
moconnor/theme-builder-css-variables

Conversation

@mathuo
Copy link
Copy Markdown
Owner

@mathuo mathuo commented Mar 28, 2026

Summary

  • Migrate spaced theme visual properties to CSS custom properties for full runtime customizability
  • Rename --dv-group-gap-border--dv-floating-group-border (scoped correctly to floating groups only)
  • Add new theme variables: --dv-floating-group-dragging-opacity, --dv-drag-over-border
  • Remove dead --dv-group-border-radius variable (was silently overridden by !important, had no effect)
  • Delete unused _sash-handle-mixin.scss
  • Add interactive theme builder side panel to the demo with live CSS override controls and code export

Test plan

  • Verify spaced themes render correctly (padding, border-radius, gaps)
  • Verify drag-over overlay shows border on spaced themes
  • Verify floating group dragging opacity applies
  • Open theme builder panel in demo, change CSS overrides, verify live updates
  • Export code snippet from theme builder, verify it's valid
  • Switch base themes in demo, verify theme builder reads correct computed defaults

🤖 Generated with Claude Code

…e theme builder

- Migrate spaced theme visual properties (border-radius, padding, etc.) to CSS custom properties
- Add --dv-floating-group-border, --dv-floating-group-dragging-opacity, --dv-drag-over-border variables
- Rename --dv-group-gap-border to --dv-floating-group-border (floating groups only)
- Remove dead --dv-group-border-radius variable (overridden by !important, had no effect)
- Delete unused _sash-handle-mixin.scss
- Add interactive theme builder side panel to demo with live CSS override controls

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 884bd6f:

Sandbox Source
dockview-app Configuration
editor-gridview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
nativeapp-dockview Configuration
rendering-dockview Configuration

@sonarqubecloud
Copy link
Copy Markdown

@mathuo mathuo merged commit 51505a6 into master Mar 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant