[CI only – do not merge] fix(openapi): honor pullPolicy - #1
Open
marxus wants to merge 1 commit into
Open
Conversation
The schema.source: OpenAPI path installed every synthesized CRD from the provider's discovery unconditionally, ignoring pullPolicy and any binding. Against a kcp workspace this mirrors the whole built-in *.kcp.io system surface (apis/tenancy/topology/cache/core) onto the consumer, not just the API the consumer bound. Split discovery from install so OpenAPI behaves like the CRD source: - discoverAndInstall (OpenAPI) now only synthesizes candidate CRDs to populate status.exportedAPIs; it installs nothing. Keeping exportedAPIs populated is what lets a ClusterBinding go Ready (not APINotExported), so status + related-resource sync keep working against kcp. - pullPolicy: All eager-install in Reconcile is now source-aware (OpenAPI synthesizes+installs; CRD pulls the provider object) — no regression. - pullPolicy: Bound installs on demand in the binding reconciler, only the CRD for the referenced API (kcp is CRD-less, so it synthesizes it). - pullPolicy: None installs nothing; the user manages the CRD. Update the schema-source e2e test to assert the new contract: under Bound the Connection installs nothing until a binding references the API, and the binding then installs the synthesized CRD. Result: source: OpenAPI + pullPolicy: Bound installs only bound APIs; kcp system groups no longer leak onto the consumer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Amit Marcus <marxus@gmail.com>
marxus
force-pushed
the
fix/openapi-honor-pullpolicy
branch
from
August 11, 2026 10:48
0caf9be to
6409d62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-PR to run fork CI on the fix branch (mirrors upstream kbind-dev#610). Do not merge.