Save InPlaceEditor changes when focus moves outside#11304
Open
ClarenceChoo wants to merge 1 commit into
Open
Conversation
ClarenceChoo
marked this pull request as ready for review
July 20, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
InPlaceEditorreturned early for every blur event with a non-nullrelatedTarget. As a result, moving focus to another button, link, or input left the editor open and neither saved nor canceled the change.Fixes #11303.
Solution
focusinevent, before the destination's click handler runs.SelectInputeditor.relatedTarget.Impact
Tabbing or clicking from an
InPlaceEditorto an outside focusable control now saves by default, or cancels whencancelOnBluris enabled. Focus moves to built-in action buttons and portalled editor controls continue to stay in edit mode.Verification
corepack yarn test-unit --runTestsByPath packages/ra-ui-materialui/src/input/InPlaceEditor/InPlaceEditor.spec.tsx --runInBandcorepack yarn eslint packages/ra-ui-materialui/src/input/InPlaceEditor/InPlaceEditor.tsx packages/ra-ui-materialui/src/input/InPlaceEditor/InPlaceEditor.spec.tsxcorepack yarn workspace ra-core buildcorepack yarn workspace ra-ui-materialui build